hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@apache.org
Subject git commit: HBASE-12130 HBASE-11980 calls hflush and hsync doing near double the syncing work
Date Wed, 01 Oct 2014 21:11:56 GMT
Repository: hbase
Updated Branches:
  refs/heads/master 915b33863 -> 0d45272e4


HBASE-12130 HBASE-11980 calls hflush and hsync doing near double the syncing work


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/0d45272e
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/0d45272e
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/0d45272e

Branch: refs/heads/master
Commit: 0d45272e40ac0a87f7875811d3923f16cc2446c4
Parents: 915b338
Author: stack <stack@apache.org>
Authored: Wed Oct 1 14:11:48 2014 -0700
Committer: stack <stack@apache.org>
Committed: Wed Oct 1 14:11:48 2014 -0700

----------------------------------------------------------------------
 .../apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/0d45272e/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java
index 14ffa45..fe2eac9 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java
@@ -163,8 +163,11 @@ public class ProtobufLogWriter extends WriterBase {
   @Override
   public void sync() throws IOException {
     try {
+      // This looks to be a noop but its what we have always done.  Leaving for now.
+      this.output.flush();
+      // TODO: Add in option to call hsync. See HBASE-5954 Allow proper fsync support for
HBase
+      //
       this.output.hflush();
-      this.output.hsync();
     } catch (NullPointerException npe) {
       // Concurrent close...
       throw new IOException(npe);


Mime
View raw message