hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anoopsamj...@apache.org
Subject git commit: HBASE-11919 Remove the deprecated pre/postGet CP hook.
Date Tue, 09 Sep 2014 18:07:22 GMT
Repository: hbase
Updated Branches:
  refs/heads/branch-1 d10b9e3a2 -> 3261cb352


HBASE-11919 Remove the deprecated pre/postGet CP hook.


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/3261cb35
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/3261cb35
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/3261cb35

Branch: refs/heads/branch-1
Commit: 3261cb352bfc18bebd4e4ce1ed03e67709402098
Parents: d10b9e3
Author: anoopsjohn <anoopsamjohn@gmail.com>
Authored: Tue Sep 9 23:36:50 2014 +0530
Committer: anoopsjohn <anoopsamjohn@gmail.com>
Committed: Tue Sep 9 23:36:50 2014 +0530

----------------------------------------------------------------------
 .../hbase/coprocessor/BaseRegionObserver.java   | 44 --------------------
 .../hbase/coprocessor/RegionObserver.java       | 18 --------
 2 files changed, 62 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/3261cb35/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
index 1a1b2ac..b5a8122 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
@@ -16,7 +16,6 @@
 package org.apache.hadoop.hbase.coprocessor;
 
 import java.io.IOException;
-import java.util.ArrayList;
 import java.util.List;
 import java.util.NavigableSet;
 
@@ -28,8 +27,6 @@ import org.apache.hadoop.hbase.Cell;
 import org.apache.hadoop.hbase.CoprocessorEnvironment;
 import org.apache.hadoop.hbase.HBaseInterfaceAudience;
 import org.apache.hadoop.hbase.HRegionInfo;
-import org.apache.hadoop.hbase.KeyValue;
-import org.apache.hadoop.hbase.KeyValueUtil;
 import org.apache.hadoop.hbase.client.Append;
 import org.apache.hadoop.hbase.client.Delete;
 import org.apache.hadoop.hbase.client.Durability;
@@ -235,54 +232,13 @@ public abstract class BaseRegionObserver implements RegionObserver {
   @Override
   public void preGetOp(final ObserverContext<RegionCoprocessorEnvironment> e,
       final Get get, final List<Cell> results) throws IOException {
-    // By default we are executing the deprecated preGet to support legacy RegionObservers
-    // We may use the results coming in and we may return the results going out.
-    List<KeyValue> kvs = new ArrayList<KeyValue>(results.size());
-    for (Cell c : results) {
-      kvs.add(KeyValueUtil.ensureKeyValue(c));
-    }
-    preGet(e, get, kvs);
-    results.clear();
-    results.addAll(kvs);
-  }
-
-  /**
-   * WARNING: please override preGetOp instead of this method.  This is to maintain some
-   * compatibility and to ease the transition from 0.94 -> 0.96.  It is super inefficient!
-   */
-  @Deprecated
-  @Override
-  public void preGet(final ObserverContext<RegionCoprocessorEnvironment> c, final Get
get,
-      final List<KeyValue> result)
-    throws IOException {
   }
 
   @Override
   public void postGetOp(final ObserverContext<RegionCoprocessorEnvironment> e,
       final Get get, final List<Cell> results) throws IOException {
-    // By default we are executing the deprecated preGet to support legacy RegionObservers
-    // We may use the results coming in and we may return the results going out.
-    List<KeyValue> kvs = new ArrayList<KeyValue>(results.size());
-    for (Cell c : results) {
-      kvs.add(KeyValueUtil.ensureKeyValue(c));
-    }
-    postGet(e, get, kvs);
-    results.clear();
-    results.addAll(kvs);
-  }
-
-  /**
-   * WARNING: please override postGetOp instead of this method.  This is to maintain some
-   * compatibility and to ease the transition from 0.94 -> 0.96.  It is super inefficient!
-   */
-  @Deprecated
-  @Override
-  public void postGet(final ObserverContext<RegionCoprocessorEnvironment> c, final
Get get,
-      final List<KeyValue> result)
-    throws IOException {
   }
 
-  
   @Override
   public boolean preExists(final ObserverContext<RegionCoprocessorEnvironment> e,
       final Get get, final boolean exists) throws IOException {

http://git-wip-us.apache.org/repos/asf/hbase/blob/3261cb35/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
index 3425a12..8be552e 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
@@ -476,15 +476,6 @@ public interface RegionObserver extends Coprocessor {
     throws IOException;
 
   /**
-   * WARNING: please override preGetOp instead of this method.  This is to maintain some
-   * compatibility and to ease the transition from 0.94 -> 0.96.
-   */
-  @Deprecated
-  void preGet(final ObserverContext<RegionCoprocessorEnvironment> c, final Get get,
-      final List<KeyValue> result)
-    throws IOException;
-
-  /**
    * Called after the client performs a Get
    * <p>
    * Call CoprocessorEnvironment#complete to skip any subsequent chained
@@ -499,15 +490,6 @@ public interface RegionObserver extends Coprocessor {
     throws IOException;
 
   /**
-   * WARNING: please override postGetOp instead of this method.  This is to maintain some
-   * compatibility and to ease the transition from 0.94 -> 0.96.
-   */
-  @Deprecated
-  void postGet(final ObserverContext<RegionCoprocessorEnvironment> c, final Get get,
-      final List<KeyValue> result)
-    throws IOException;
-
-  /**
    * Called before the client tests for existence using a Get.
    * <p>
    * Call CoprocessorEnvironment#bypass to skip default actions


Mime
View raw message