hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ecl...@apache.org
Subject git commit: HBASE-12115 Fix TableInputFormatBase.reverseDNS for ipv6 addresses
Date Tue, 30 Sep 2014 20:34:54 GMT
Repository: hbase
Updated Branches:
  refs/heads/0.98 523620329 -> 904278888


HBASE-12115 Fix TableInputFormatBase.reverseDNS for ipv6 addresses

Summary: Hadoop's DNS.reverDns function cannot handle Inet6Address properly and throws Runtime
Exceptions.

Test Plan: Added Unit test to test the particular case.

Differential Revision: https://reviews.facebook.net/D24225

Signed-off-by: Elliott Clark <eclark@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/90427888
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/90427888
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/90427888

Branch: refs/heads/0.98
Commit: 904278888568f5f7f89afe0da333ee0d8531f621
Parents: 5236203
Author: manukranthk <manukranthk@fb.com>
Authored: Mon Sep 29 16:31:32 2014 -0700
Committer: Elliott Clark <eclark@apache.org>
Committed: Tue Sep 30 13:33:12 2014 -0700

----------------------------------------------------------------------
 .../hbase/mapreduce/TableInputFormatBase.java   | 16 ++++--
 .../mapreduce/TestTableInputFormatBase.java     | 54 ++++++++++++++++++++
 2 files changed, 67 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/90427888/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java
index b8b2842..1fadced 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java
@@ -23,6 +23,7 @@ import java.io.InterruptedIOException;
 import java.net.InetAddress;
 import java.net.InetSocketAddress;
 import java.text.MessageFormat;
+import java.net.UnknownHostException;
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
@@ -222,11 +223,20 @@ extends InputFormat<ImmutableBytesWritable, Result> {
     return splits;
   }
   
-  private String reverseDNS(InetAddress ipAddress) throws NamingException {
+  public String reverseDNS(InetAddress ipAddress) throws NamingException, UnknownHostException
{
     String hostName = this.reverseDNSCacheMap.get(ipAddress);
     if (hostName == null) {
-      hostName = Strings.domainNamePointerToHostName(
-        DNS.reverseDns(ipAddress, this.nameServer));
+      String ipAddressString = null;
+      try {
+        ipAddressString = DNS.reverseDns(ipAddress, null);
+      } catch (Exception e) {
+        // We can use InetAddress in case the jndi failed to pull up the reverse DNS entry
from the
+        // name service. Also, in case of ipv6, we need to use the InetAddress since resolving
+        // reverse DNS using jndi doesn't work well with ipv6 addresses.
+        ipAddressString = InetAddress.getByName(ipAddress.getHostAddress()).getHostName();
+      }
+      if (ipAddressString == null) throw new UnknownHostException("No host found for " +
ipAddress);
+      hostName = Strings.domainNamePointerToHostName(ipAddressString);
       this.reverseDNSCacheMap.put(ipAddress, hostName);
     }
     return hostName;

http://git-wip-us.apache.org/repos/asf/hbase/blob/90427888/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatBase.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatBase.java
b/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatBase.java
new file mode 100644
index 0000000..e0d228a
--- /dev/null
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatBase.java
@@ -0,0 +1,54 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.mapreduce;
+
+import static org.junit.Assert.*;
+
+import java.net.Inet6Address;
+import java.net.InetAddress;
+import java.net.UnknownHostException;
+
+import javax.naming.NamingException;
+import org.apache.hadoop.hbase.SmallTests;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+@Category(SmallTests.class)
+public class TestTableInputFormatBase {
+  @Test
+  public void testTableInputFormatBaseReverseDNSForIPv6()
+      throws UnknownHostException, NamingException {
+    String address = "ipv6.google.com";
+    String localhost = null;
+    InetAddress addr = null;
+    TableInputFormat inputFormat = new TableInputFormat();
+    try {
+      localhost = InetAddress.getByName(address).getCanonicalHostName();
+      addr = Inet6Address.getByName(address);
+    } catch (UnknownHostException e) {
+      // google.com is down, we can probably forgive this test.
+      return;
+    }
+    System.out.println("Should retrun the hostname for this host " +
+        localhost + " addr : " + addr);
+    String actualHostName = inputFormat.reverseDNS(addr);
+    assertEquals("Should retrun the hostname for this host. Expected : " +
+        localhost + " Actual : " + actualHostName, localhost, actualHostName);
+  }
+}


Mime
View raw message