hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From li...@apache.org
Subject svn commit: r1569879 - /hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWithBloomError.java
Date Wed, 19 Feb 2014 19:18:36 GMT
Author: liyin
Date: Wed Feb 19 19:18:36 2014
New Revision: 1569879

URL: http://svn.apache.org/r1569879
Log:
[HBASE-10538] Fix mis-use of Scan in TestScanWithBloomError

Author: daviddeng

Summary: Make stopRow always exclusive as the comments of Scan

Test Plan: Run TestScanWithBloomError

Reviewers: manukranthk, liyintang

Reviewed By: liyintang

CC: hbase-eng@

Differential Revision: https://phabricator.fb.com/D1180454

Task ID: 3761794

Modified:
    hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWithBloomError.java

Modified: hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWithBloomError.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWithBloomError.java?rev=1569879&r1=1569878&r2=1569879&view=diff
==============================================================================
--- hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWithBloomError.java
(original)
+++ hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWithBloomError.java
Wed Feb 19 19:18:36 2014
@@ -1,5 +1,11 @@
 package org.apache.hadoop.hbase.regionserver;
 
+import static org.apache.hadoop.hbase.regionserver.TestMultiColumnScanner.FAMILY;
+import static org.apache.hadoop.hbase.regionserver.TestMultiColumnScanner.FAMILY_BYTES;
+import static org.apache.hadoop.hbase.regionserver.TestMultiColumnScanner.createValue;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -21,9 +27,7 @@ import org.apache.hadoop.hbase.KeyValue;
 import org.apache.hadoop.hbase.KeyValueTestUtil;
 import org.apache.hadoop.hbase.client.Put;
 import org.apache.hadoop.hbase.client.Scan;
-import org.apache.hadoop.hbase.io.encoding.DataBlockEncoding;
 import org.apache.hadoop.hbase.io.hfile.Compression;
-import org.apache.hadoop.hbase.io.hfile.HFile;
 import org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter;
 import org.apache.hadoop.hbase.util.Bytes;
 import org.junit.Before;
@@ -32,9 +36,6 @@ import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
 import org.junit.runners.Parameterized.Parameters;
 
-import static org.apache.hadoop.hbase.regionserver.TestMultiColumnScanner.*;
-import static org.junit.Assert.*;
-
 /**
  * Test a multi-column scanner when there is a Bloom filter false-positive.
  * This is needed for the multi-column Bloom filter optimization.
@@ -95,7 +96,7 @@ public class TestScanWithBloomError {
   private void scanColSet(int[] colSet, int[] expectedResultCols)
       throws IOException {
     LOG.info("Scanning column set: " + Arrays.toString(colSet));
-    Scan scan = new Scan(ROW_BYTES, ROW_BYTES);
+    Scan scan = new Scan(ROW_BYTES, Bytes.nextOf(ROW_BYTES));
     addColumnSetToScan(scan, colSet);
     RegionScanner scanner = (RegionScanner)
         region.getScanner(scan);



Mime
View raw message