Return-Path: X-Original-To: apmail-hbase-commits-archive@www.apache.org Delivered-To: apmail-hbase-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3D99E10C2A for ; Mon, 13 Jan 2014 01:13:40 +0000 (UTC) Received: (qmail 46375 invoked by uid 500); 13 Jan 2014 01:13:28 -0000 Delivered-To: apmail-hbase-commits-archive@hbase.apache.org Received: (qmail 46317 invoked by uid 500); 13 Jan 2014 01:13:21 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 46305 invoked by uid 99); 13 Jan 2014 01:13:17 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jan 2014 01:13:17 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jan 2014 01:13:15 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 6F9B52388868; Mon, 13 Jan 2014 01:12:54 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1557636 - /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java Date: Mon, 13 Jan 2014 01:12:54 -0000 To: commits@hbase.apache.org From: tedyu@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20140113011254.6F9B52388868@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: tedyu Date: Mon Jan 13 01:12:54 2014 New Revision: 1557636 URL: http://svn.apache.org/r1557636 Log: HBASE-10294 Some synchronization on ServerManager#onlineServers can be removed Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java?rev=1557636&r1=1557635&r2=1557636&view=diff ============================================================================== --- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java (original) +++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java Mon Jan 13 01:12:54 2014 @@ -421,9 +421,7 @@ public class ServerManager { */ public Map getOnlineServers() { // Presumption is that iterating the returned Map is OK. - synchronized (this.onlineServers) { - return Collections.unmodifiableMap(this.onlineServers); - } + return Collections.unmodifiableMap(this.onlineServers); }