hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From te...@apache.org
Subject svn commit: r1554234 - /hbase/trunk/dev-support/test-patch.sh
Date Mon, 30 Dec 2013 14:32:55 GMT
Author: tedyu
Date: Mon Dec 30 14:32:54 2013
New Revision: 1554234

URL: http://svn.apache.org/r1554234
Log:
HBASE-10224 Line length check in test-patch.sh is broken


Modified:
    hbase/trunk/dev-support/test-patch.sh

Modified: hbase/trunk/dev-support/test-patch.sh
URL: http://svn.apache.org/viewvc/hbase/trunk/dev-support/test-patch.sh?rev=1554234&r1=1554233&r2=1554234&view=diff
==============================================================================
--- hbase/trunk/dev-support/test-patch.sh (original)
+++ hbase/trunk/dev-support/test-patch.sh Mon Dec 30 14:32:54 2013
@@ -670,7 +670,7 @@ checkLineLengths () {
   MAX_LINE_LENGTH_PATCH=`expr $MAX_LINE_LENGTH + 1`
   lines=`cat $PATCH_DIR/patch | grep "^+" | grep -v "^@@" | grep -v "^+++" | grep -v "import"
| grep -v "hbase.protobuf.generated" | awk -v len="$MAX_LINE_LENGTH_PATCH" 'length ($0) >
len' | head -n 10`
   ll=`echo "$lines" | wc -l`
-  if [[ "$ll" -gt "$MAX_LINE_LENGTH_PATCH" ]]; then
+  if [[ "$ll" -gt "0" ]]; then
     JIRA_COMMENT="$JIRA_COMMENT
 
     {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
$MAX_LINE_LENGTH:



Mime
View raw message