hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From la...@apache.org
Subject svn commit: r1549920 - /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
Date Tue, 10 Dec 2013 18:24:36 GMT
Author: larsh
Date: Tue Dec 10 18:24:35 2013
New Revision: 1549920

URL: http://svn.apache.org/r1549920
Log:
HBASE-10117 Avoid synchronization in HRegionScannerImpl.isFilterDone

Modified:
    hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java

Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java?rev=1549920&r1=1549919&r2=1549920&view=diff
==============================================================================
--- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
(original)
+++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
Tue Dec 10 18:24:35 2013
@@ -3526,7 +3526,7 @@ public class HRegion implements HeapSize
     // KeyValue indicating that limit is reached when scanning
     private final KeyValue KV_LIMIT = new KeyValue();
     protected final byte[] stopRow;
-    private Filter filter;
+    private final Filter filter;
     private int batch;
     protected int isScan;
     private boolean filterClosed = false;
@@ -3666,7 +3666,7 @@ public class HRegion implements HeapSize
         outResults.addAll(tmpList);
       }
       resetFilters();
-      if (isFilterDone()) {
+      if (isFilterDoneInternal()) {
         return false;
       }
       if (region != null && region.metricsRegion != null) {
@@ -3726,6 +3726,10 @@ public class HRegion implements HeapSize
      */
     @Override
     public synchronized boolean isFilterDone() throws IOException {
+      return isFilterDoneInternal();
+    }
+
+    private boolean isFilterDoneInternal() throws IOException {
       return this.filter != null && this.filter.filterAllRemaining();
     }
 



Mime
View raw message