hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ndimi...@apache.org
Subject svn commit: r1532598 - in /hbase/trunk: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapper.java hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon
Date Tue, 15 Oct 2013 23:44:46 GMT
Author: ndimiduk
Date: Tue Oct 15 23:44:45 2013
New Revision: 1532598

URL: http://svn.apache.org/r1532598
Log:
HBASE-9771 [WebUI] Humanize store and blockcache statistics on RS

Modified:
    hbase/trunk/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapper.java
    hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon

Modified: hbase/trunk/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapper.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapper.java?rev=1532598&r1=1532597&r2=1532598&view=diff
==============================================================================
--- hbase/trunk/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapper.java
(original)
+++ hbase/trunk/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapper.java
Tue Oct 15 23:44:45 2013
@@ -113,17 +113,17 @@ public interface MetricsRegionServerWrap
   long getCheckAndMutateChecksPassed();
 
   /**
-   * Get the Size of indexes in storefiles on disk.
+   * Get the Size (in bytes) of indexes in storefiles on disk.
    */
   long getStoreFileIndexSize();
 
   /**
-   * Get the size of of the static indexes including the roots.
+   * Get the size (in bytes) of of the static indexes including the roots.
    */
   long getTotalStaticIndexSize();
 
   /**
-   * Get the size of the static bloom filters.
+   * Get the size (in bytes) of the static bloom filters.
    */
   long getTotalStaticBloomSize();
 
@@ -158,7 +158,7 @@ public interface MetricsRegionServerWrap
   int getFlushQueueSize();
 
   /**
-   * Get the size of the block cache that is free.
+   * Get the size (in bytes) of the block cache that is free.
    */
   long getBlockCacheFreeSize();
 
@@ -168,7 +168,7 @@ public interface MetricsRegionServerWrap
   long getBlockCacheCount();
 
   /**
-   * Get the total size of the block cache.
+   * Get the total size (in bytes) of the block cache.
    */
   long getBlockCacheSize();
 

Modified: hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon?rev=1532598&r1=1532597&r2=1532598&view=diff
==============================================================================
--- hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon
(original)
+++ hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon
Tue Oct 15 23:44:45 2013
@@ -120,16 +120,16 @@ MetricsRegionServerWrapper mWrap;
 
     <th>Num. Stores</th>
     <th>Num. Storefiles</th>
-    <th>Root Index Size</th>
-    <th>Index Size</th>
-    <th>Bloom Size</th>
+    <th>Root Index Size (bytes)</th>
+    <th>Index Size (bytes)</th>
+    <th>Bloom Size (bytes)</th>
 </tr>
 <tr>
-    <td><% mWrap.getNumStores() %></td>
-    <td><% mWrap.getNumStoreFiles() %></td>
-    <td><% mWrap.getStoreFileIndexSize() %></td>
-    <td><% mWrap.getTotalStaticIndexSize() %></td>
-    <td><% mWrap.getTotalStaticBloomSize() %></td>
+    <td><% StringUtils.humanReadableInt(mWrap.getNumStores()) %></td>
+    <td><% StringUtils.humanReadableInt(mWrap.getNumStoreFiles()) %></td>
+    <td><% StringUtils.humanReadableInt(mWrap.getStoreFileIndexSize()) %></td>
+    <td><% StringUtils.humanReadableInt(mWrap.getTotalStaticIndexSize()) %></td>
+    <td><% StringUtils.humanReadableInt(mWrap.getTotalStaticBloomSize()) %></td>
 </tr>
 </table>
 </%def>
@@ -159,8 +159,8 @@ MetricsRegionServerWrapper mWrap;
 </%args>
 <table class="table table-striped">
 <tr>
-    <th>Compaction queue size</th>
-    <th>Flush queue size</th>
+    <th>Compaction Queue Size</th>
+    <th>Flush Queue Size</th>
 
 </tr>
 <tr>
@@ -177,23 +177,23 @@ MetricsRegionServerWrapper mWrap;
 </%args>
 <table class="table table-striped">
 <tr>
-    <th>Cache Size</th>
-    <th>Cache Free</th>
-    <th>Cache Count</th>
-    <th>Cache Hits</th>
-    <th>Cache Misses</th>
+    <th>Cache Size (bytes)</th>
+    <th>Cache Free (bytes)</th>
+    <th>Cache Count (blocks)</th>
+    <th>Cache Hit Count</th>
+    <th>Cache Miss Count</th>
     <th>Cache Hit Ratio</th>
     <th>Cache Eviction Count</th>
 
 </tr>
 <tr>
-    <td><% mWrap.getBlockCacheSize()%></td>
-    <td><% mWrap.getBlockCacheFreeSize()%></td>
-    <td><% mWrap.getBlockCacheCount() %></td>
-    <td><% mWrap.getBlockCacheHitCount() %></td>
-    <td><% mWrap.getBlockCacheMissCount() %></td>
+    <td><% StringUtils.humanReadableInt(mWrap.getBlockCacheSize()) %></td>
+    <td><% StringUtils.humanReadableInt(mWrap.getBlockCacheFreeSize()) %></td>
+    <td><% StringUtils.humanReadableInt(mWrap.getBlockCacheCount()) %></td>
+    <td><% StringUtils.humanReadableInt(mWrap.getBlockCacheHitCount()) %></td>
+    <td><% StringUtils.humanReadableInt(mWrap.getBlockCacheMissCount()) %></td>
     <td><% mWrap.getBlockCacheHitPercent() %>%</td>
-    <td><% mWrap.getBlockCacheEvictedCount() %></td>
+    <td><% StringUtils.humanReadableInt(mWrap.getBlockCacheEvictedCount()) %></td>
 </tr>
 </table>
 </%def>



Mime
View raw message