hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From li...@apache.org
Subject svn commit: r1524511 - /hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/HMsg.java
Date Wed, 18 Sep 2013 18:18:19 GMT
Author: liyin
Date: Wed Sep 18 18:18:19 2013
New Revision: 1524511

URL: http://svn.apache.org/r1524511
Log:
[master] Move newly added enum element to the end

Author: fan

Summary:
When new element is inserted between other elements, the ordinal of later elements changes.
This offset messes up interpretation of HMsgs communication between servers.

Test Plan: Test rolling restart again and we should not see further region multipe assignment
problem.

Reviewers: aaiyer

Reviewed By: aaiyer

CC: hbase-eng@

Differential Revision: https://phabricator.fb.com/D972908

Task ID: 2843192

Modified:
    hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/HMsg.java

Modified: hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/HMsg.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/HMsg.java?rev=1524511&r1=1524510&r2=1524511&view=diff
==============================================================================
--- hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/HMsg.java (original)
+++ hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/HMsg.java Wed Sep 18 18:18:19
2013
@@ -42,6 +42,10 @@ public class HMsg implements Writable {
 
   /**
    * Message types sent between master and regionservers
+   *
+   * WARNING: Do not insert entry in between. Otherwise ordinal offset causes
+   * misinterpretation of HMsg between servers, which results in unexpected
+   * behavior during rolling restart.
    */
   public static enum Type {
     /** null message */
@@ -81,9 +85,6 @@ public class HMsg implements Writable {
     /** region server is processing open request */
     MSG_REPORT_PROCESS_OPEN,
 
-    /** region server is processing a close request */
-    MSG_REPORT_PROCESS_CLOSE,
-
     /**
      * Region server split the region associated with this message.
      *
@@ -154,6 +155,9 @@ public class HMsg implements Writable {
      * region server reports any more.
       */
     MSG_REPORT_BEGINNING_OF_THE_END,
+
+    /** region server is processing a close request */
+    MSG_REPORT_PROCESS_CLOSE,
   }
 
   private Type type = null;



Mime
View raw message