hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nkey...@apache.org
Subject svn commit: r1471272 - /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java
Date Wed, 24 Apr 2013 07:27:43 GMT
Author: nkeywal
Date: Wed Apr 24 07:27:43 2013
New Revision: 1471272

URL: http://svn.apache.org/r1471272
Log:
HBASE-8380 NPE in HBaseClient.readResponse

Modified:
    hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java

Modified: hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java?rev=1471272&r1=1471271&r2=1471272&view=diff
==============================================================================
--- hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java
(original)
+++ hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java
Wed Apr 24 07:27:43 2013
@@ -392,7 +392,7 @@ public class HBaseClient {
 
       if (LOG.isDebugEnabled()) {
         LOG.debug("Use " + authMethod + " authentication for protocol "
-            + protocol.getSimpleName());
+            + (protocol == null ? "null" : protocol.getSimpleName()));
       }
       reloginMaxBackoff = conf.getInt("hbase.security.relogin.maxbackoff", 5000);
       this.remoteId = remoteId;
@@ -811,7 +811,7 @@ public class HBaseClient {
                 ticket = ticket.getRealUser();
               }
             }
-            boolean continueSasl = false;
+            boolean continueSasl;
             try {
               if (ticket == null) {
                 throw new NullPointerException("ticket is null");
@@ -855,7 +855,7 @@ public class HBaseClient {
         }
       } catch (Throwable t) {
         failedServers.addToFailedServers(remoteId.address);
-        IOException e = null;
+        IOException e;
         if (t instanceof IOException) {
           e = (IOException)t;
           markClosed(e);
@@ -1007,14 +1007,16 @@ public class HBaseClient {
             if (call != null) call.setException(re);
           }
         } else {
-          Message rpcResponseType;
-          try {
-            // TODO: Why pb engine pollution in here in this class?  FIX.
-            rpcResponseType =
-              ProtobufRpcClientEngine.Invoker.getReturnProtoType(
-                reflectionCache.getMethod(remoteId.getProtocol(), call.method.getName()));
-          } catch (Exception e) {
-            throw new RuntimeException(e); //local exception
+          Message rpcResponseType = null;
+          if (call != null){
+            try {
+              // TODO: Why pb engine pollution in here in this class?  FIX.
+              rpcResponseType =
+                ProtobufRpcClientEngine.Invoker.getReturnProtoType(
+                  reflectionCache.getMethod(remoteId.getProtocol(), call.method.getName()));
+            } catch (Exception e) {
+              throw new RuntimeException(e); //local exception
+            }
           }
           Message value = null;
           if (rpcResponseType != null) {
@@ -1474,4 +1476,4 @@ public class HBaseClient {
       return hashcode;
     }
   }
-}
\ No newline at end of file
+}



Mime
View raw message