hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From li...@apache.org
Subject svn commit: r1459465 - /hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
Date Thu, 21 Mar 2013 18:53:29 GMT
Author: liyin
Date: Thu Mar 21 18:53:29 2013
New Revision: 1459465

URL: http://svn.apache.org/r1459465
Log:
[0.89-fb] [HBASE-7852] Ensure that the command line options are respected.

Author: aaiyer

Summary:
LoadIncrementalHFiles should extract the config options after
Tool.run() is called, to ensure that the command line overrides
are respected.

Test Plan:
Test out on the dev cluster, with command line overrides.
Ensure that the command line override for configuration settings is
respected

Reviewers: adela, liyintang

Reviewed By: liyintang

CC: hbase-eng@, ryandm

Differential Revision: https://phabricator.fb.com/D693206

Modified:
    hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java

Modified: hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java?rev=1459465&r1=1459464&r2=1459465&view=diff
==============================================================================
--- hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
(original)
+++ hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
Thu Mar 21 18:53:29 2013
@@ -76,8 +76,6 @@ public class LoadIncrementalHFiles exten
 
   public LoadIncrementalHFiles(Configuration conf) {
     super(conf);
-    assignSeqIds = conf.getBoolean(ASSIGN_SEQ_IDS, true);
-    exitOnFirstFailure = conf.getBoolean(EXIT_ON_FIRST_FAILURE, true);
   }
 
   public LoadIncrementalHFiles() {
@@ -353,6 +351,10 @@ public class LoadIncrementalHFiles exten
     Path hfofDir = new Path(args[0]);
     HTable table = new HTable(getConf(), args[1]);
 
+    Configuration conf = this.getConf();
+    assignSeqIds = conf.getBoolean(ASSIGN_SEQ_IDS, true);
+    exitOnFirstFailure = conf.getBoolean(EXIT_ON_FIRST_FAILURE, true);
+
     doBulkLoad(hfofDir, table);
     return 0;
   }



Mime
View raw message