Return-Path: X-Original-To: apmail-hbase-commits-archive@www.apache.org Delivered-To: apmail-hbase-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D49C2D3C3 for ; Sat, 22 Dec 2012 13:44:10 +0000 (UTC) Received: (qmail 60419 invoked by uid 500); 22 Dec 2012 13:44:10 -0000 Delivered-To: apmail-hbase-commits-archive@hbase.apache.org Received: (qmail 60176 invoked by uid 500); 22 Dec 2012 13:44:08 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 60163 invoked by uid 99); 22 Dec 2012 13:44:08 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 Dec 2012 13:44:08 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 Dec 2012 13:44:04 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id CF6CF2388962; Sat, 22 Dec 2012 13:43:42 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1425281 - in /hbase/trunk: dev-support/ hbase-server/src/main/java/org/apache/hadoop/hbase/client/coprocessor/ hbase-server/src/main/java/org/apache/hadoop/hbase/filter/ hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ hbase-se... Date: Sat, 22 Dec 2012 13:43:42 -0000 To: commits@hbase.apache.org From: eclark@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20121222134342.CF6CF2388962@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: eclark Date: Sat Dec 22 13:43:41 2012 New Revision: 1425281 URL: http://svn.apache.org/viewvc?rev=1425281&view=rev Log: HBASE-7426 Fix PreCheckin script to error out when there are Javadoc errors. Modified: hbase/trunk/dev-support/test-patch.properties hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/coprocessor/Batch.java hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/filter/FirstKeyValueMatchingQualifiersFilter.java hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ChecksumUtil.java hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationHLogReaderManager.java hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/TokenProvider.java Modified: hbase/trunk/dev-support/test-patch.properties URL: http://svn.apache.org/viewvc/hbase/trunk/dev-support/test-patch.properties?rev=1425281&r1=1425280&r2=1425281&view=diff ============================================================================== --- hbase/trunk/dev-support/test-patch.properties (original) +++ hbase/trunk/dev-support/test-patch.properties Sat Dec 22 13:43:41 2012 @@ -20,4 +20,4 @@ MAVEN_OPTS="-Xmx3g" OK_RELEASEAUDIT_WARNINGS=84 OK_FINDBUGS_WARNINGS=517 -OK_JAVADOC_WARNINGS=169 +OK_JAVADOC_WARNINGS=0 Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/coprocessor/Batch.java URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/coprocessor/Batch.java?rev=1425281&r1=1425280&r2=1425281&view=diff ============================================================================== --- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/coprocessor/Batch.java (original) +++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/coprocessor/Batch.java Sat Dec 22 13:43:41 2012 @@ -37,15 +37,15 @@ public abstract class Batch { * *

* When used with - * {@link org.apache.hadoop.hbase.client.HTable#coprocessorExec(Class, byte[], byte[], org.apache.hadoop.hbase.client.coprocessor.Batch.Call, org.apache.hadoop.hbase.client.coprocessor.Batch.Callback)} + * {@link org.apache.hadoop.hbase.client.HTable#coprocessorService(Class, byte[], byte[], org.apache.hadoop.hbase.client.coprocessor.Batch.Call)} * the implementations {@link Batch.Call#call(Object)} method will be invoked * with a proxy to the - * {@link org.apache.hadoop.hbase.ipc.CoprocessorProtocol} + * {@link org.apache.hadoop.hbase.coprocessor.CoprocessorService} * sub-type instance. *

* @see org.apache.hadoop.hbase.client.coprocessor - * @see org.apache.hadoop.hbase.client.HTable#coprocessorExec(Class, byte[], byte[], org.apache.hadoop.hbase.client.coprocessor.Batch.Call) - * @see org.apache.hadoop.hbase.client.HTable#coprocessorExec(Class, byte[], byte[], org.apache.hadoop.hbase.client.coprocessor.Batch.Call, org.apache.hadoop.hbase.client.coprocessor.Batch.Callback) + * @see org.apache.hadoop.hbase.client.HTable#coprocessorService(byte[]) + * @see org.apache.hadoop.hbase.client.HTable#coprocessorService(Class, byte[], byte[], org.apache.hadoop.hbase.client.coprocessor.Batch.Call) * @param the instance type to be passed to * {@link Batch.Call#call(Object)} * @param the return type from {@link Batch.Call#call(Object)} @@ -60,13 +60,13 @@ public abstract class Batch { * *

* When used with - * {@link org.apache.hadoop.hbase.client.HTable#coprocessorExec(Class, byte[], byte[], org.apache.hadoop.hbase.client.coprocessor.Batch.Call, org.apache.hadoop.hbase.client.coprocessor.Batch.Callback)}, + * {@link org.apache.hadoop.hbase.client.HTable#coprocessorService(Class, byte[], byte[], org.apache.hadoop.hbase.client.coprocessor.Batch.Call)} * the implementation's {@link Batch.Callback#update(byte[], byte[], Object)} * method will be called with the {@link Batch.Call#call(Object)} return value * from each region in the selected range. *

* @param the return type from the associated {@link Batch.Call#call(Object)} - * @see org.apache.hadoop.hbase.client.HTable#coprocessorExec(Class, byte[], byte[], org.apache.hadoop.hbase.client.coprocessor.Batch.Call, org.apache.hadoop.hbase.client.coprocessor.Batch.Callback) + * @see org.apache.hadoop.hbase.client.HTable#coprocessorService(Class, byte[], byte[], org.apache.hadoop.hbase.client.coprocessor.Batch.Call) */ public static interface Callback { public void update(byte[] region, byte[] row, R result); Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/filter/FirstKeyValueMatchingQualifiersFilter.java URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/filter/FirstKeyValueMatchingQualifiersFilter.java?rev=1425281&r1=1425280&r2=1425281&view=diff ============================================================================== --- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/filter/FirstKeyValueMatchingQualifiersFilter.java (original) +++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/filter/FirstKeyValueMatchingQualifiersFilter.java Sat Dec 22 13:43:41 2012 @@ -37,7 +37,8 @@ import java.util.TreeSet; *

* Note : It may emit KVs which do not have the given columns in them, if * these KVs happen to occur before a KV which does have a match. Given this - * caveat, this filter is only useful for special cases like {@link RowCounter}. + * caveat, this filter is only useful for special cases + * like {@link org.apache.hadoop.hbase.mapreduce.RowCounter}. *

*/ @InterfaceAudience.Public Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ChecksumUtil.java URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ChecksumUtil.java?rev=1425281&r1=1425280&r2=1425281&view=diff ============================================================================== --- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ChecksumUtil.java (original) +++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ChecksumUtil.java Sat Dec 22 13:43:41 2012 @@ -54,7 +54,7 @@ public class ChecksumUtil { * compute checkums from * @param endOffset ending offset in the indata stream upto * which checksums needs to be computed - * @param outData the output buffer where checksum values are written + * @param outdata the output buffer where checksum values are written * @param outOffset the starting offset in the outdata where the * checksum values are written * @param checksumType type of checksum Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java?rev=1425281&r1=1425280&r2=1425281&view=diff ============================================================================== --- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java (original) +++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java Sat Dec 22 13:43:41 2012 @@ -222,7 +222,6 @@ public class FixedFileTrailer { * {@link #serialize(DataOutputStream)}. * * @param inputStream - * @param version * @throws IOException */ void deserialize(DataInputStream inputStream) throws IOException { Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java?rev=1425281&r1=1425280&r2=1425281&view=diff ============================================================================== --- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java (original) +++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java Sat Dec 22 13:43:41 2012 @@ -1137,7 +1137,7 @@ public final class RequestConverter { * @param family optional column family * @param qualifier optional qualifier * @param actions the permissions to be granted - * @return A {@link AccessControlProtos.GrantRequest) + * @return A {@link AccessControlProtos} GrantRequest */ public static AccessControlProtos.GrantRequest buildGrantRequest( String username, byte[] table, byte[] family, byte[] qualifier, @@ -1173,7 +1173,7 @@ public final class RequestConverter { * @param family optional column family * @param qualifier optional qualifier * @param actions the permissions to be revoked - * @return A {@link AccessControlProtos.RevokeRequest) + * @return A {@link AccessControlProtos} RevokeRequest */ public static AccessControlProtos.RevokeRequest buildRevokeRequest( String username, byte[] table, byte[] family, byte[] qualifier, Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationHLogReaderManager.java URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationHLogReaderManager.java?rev=1425281&r1=1425280&r2=1425281&view=diff ============================================================================== --- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationHLogReaderManager.java (original) +++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationHLogReaderManager.java Sat Dec 22 13:43:41 2012 @@ -57,7 +57,7 @@ public class ReplicationHLogReaderManage /** * Opens the file at the current position * @param path - * @return + * @return an HLog reader. * @throws IOException */ public HLog.Reader openReader(Path path) throws IOException { Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java?rev=1425281&r1=1425280&r2=1425281&view=diff ============================================================================== --- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java (original) +++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java Sat Dec 22 13:43:41 2012 @@ -92,13 +92,13 @@ import static org.apache.hadoop.hbase.pr * *

* To perform authorization checks, {@code AccessController} relies on the - * {@link org.apache.hadoop.hbase.ipc.SecureRpcEngine} being loaded to provide + * {@link org.apache.hadoop.hbase.ipc.RpcServerEngine} being loaded to provide * the user identities for remote requests. *

* *

* The access control lists used for authorization can be manipulated via the - * exposed {@link AccessControlService.Interface} implementation, and the associated + * exposed {@link AccessControlService} Interface implementation, and the associated * {@code grant}, {@code revoke}, and {@code user_permission} HBase shell * commands. *

Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/TokenProvider.java URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/TokenProvider.java?rev=1425281&r1=1425280&r2=1425281&view=diff ============================================================================== --- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/TokenProvider.java (original) +++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/TokenProvider.java Sat Dec 22 13:43:41 2012 @@ -44,7 +44,7 @@ import org.apache.hadoop.security.token. /** * Provides a service for obtaining authentication tokens via the - * {@link AuthenticationProtos.AuthenticationService} coprocessor service. + * {@link AuthenticationProtos} AuthenticationService coprocessor service. */ public class TokenProvider implements AuthenticationProtos.AuthenticationService.Interface, Coprocessor, CoprocessorService { @@ -73,7 +73,7 @@ public class TokenProvider implements Au } /** - * @param ugi + * @param ugi A user group information. * @return true if delegation token operation is allowed */ private boolean isAllowedDelegationTokenOp(UserGroupInformation ugi) throws IOException {