hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@apache.org
Subject svn commit: r1422134 - in /hbase/trunk: ./ hbase-common/src/main/java/org/apache/hadoop/hbase/ hbase-common/src/main/java/org/apache/hadoop/hbase/util/ hbase-common/src/main/java/org/apache/hbase/ hbase-hadoop-compat/src/main/java/org/apache/hadoop/hba...
Date Fri, 14 Dec 2012 22:37:58 GMT
Author: stack
Date: Fri Dec 14 22:37:55 2012
New Revision: 1422134

URL: http://svn.apache.org/viewvc?rev=1422134&view=rev
Log:
HBASE-7356 Fix all javadoc warnings in all modules but hbase-server

Modified:
    hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
    hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueTool.java
    hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java
    hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteRange.java
    hbase/trunk/hbase-common/src/main/java/org/apache/hbase/Cell.java
    hbase/trunk/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceFactory.java
    hbase/trunk/hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/mapreduce/JobUtil.java
    hbase/trunk/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/mapreduce/JobUtil.java
    hbase/trunk/pom.xml

Modified: hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java?rev=1422134&r1=1422133&r2=1422134&view=diff
==============================================================================
--- hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java (original)
+++ hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java Fri Dec 14
22:37:55 2012
@@ -2317,7 +2317,7 @@ public class KeyValue implements Cell, H
    * @param out
    * @return Length written on stream
    * @throws IOException
-   * @see {@link #create(DataInput)} for the inverse function
+   * @see #create(DataInput) for the inverse function
    */
   public static long write(final KeyValue kv, final DataOutput out) throws IOException {
     // This is how the old Writables write used to serialize KVs.  Need to figure way to
make it work for all

Modified: hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueTool.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueTool.java?rev=1422134&r1=1422133&r2=1422134&view=diff
==============================================================================
--- hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueTool.java (original)
+++ hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueTool.java Fri Dec
14 22:37:55 2012
@@ -189,7 +189,7 @@ public class KeyValueTool {
    *
    * Remember timestamps are sorted reverse chronologically.
    * @param in
-   * @return
+   * @return previous key
    */
   public static KeyValue previousKey(final KeyValue in) {
     return KeyValue.createFirstOnRow(CellTool.getRowArray(in), CellTool.getFamilyArray(in),

Modified: hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java?rev=1422134&r1=1422133&r2=1422134&view=diff
==============================================================================
--- hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java
(original)
+++ hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java
Fri Dec 14 22:37:55 2012
@@ -318,7 +318,7 @@ public final class ByteBufferUtils {
       }
     }
   }
-  
+
   /**
    * Copy from the InputStream to a new heap ByteBuffer until the InputStream is exhausted.
    */
@@ -378,7 +378,7 @@ public final class ByteBufferUtils {
    * @param leftOffset Offset in left array.
    * @param leftLength Length of left array.
    * @param right Array to be compared.
-   * @param rightArray Offset in right array.
+   * @param rightOffset Offset in right array.
    * @param rightLength Length of right array.
    */
   public static int findCommonPrefix(
@@ -402,7 +402,7 @@ public final class ByteBufferUtils {
    * @param lengthLeft Length of the first part.
    * @param offsetRight Beginning of the second part.
    * @param lengthRight Length of the second part.
-   * @return
+   * @return True if equal
    */
   public static boolean arePartsEqual(ByteBuffer buffer,
       int offsetLeft, int lengthLeft,

Modified: hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteRange.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteRange.java?rev=1422134&r1=1422133&r2=1422134&view=diff
==============================================================================
--- hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteRange.java (original)
+++ hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteRange.java Fri
Dec 14 22:37:55 2012
@@ -147,7 +147,7 @@ public class ByteRange implements Compar
   /**
    * Create a new ByteRange with new backing byte[] and copy the state of this range into
the new
    * range.  Copy the hash over if it is already calculated.
-   * @return 
+   * @return Deep copy
    */
   public ByteRange deepCopy() {
     ByteRange clone = new ByteRange(deepCopyToNewArray());
@@ -161,7 +161,6 @@ public class ByteRange implements Compar
    * Wrapper for System.arraycopy.  Copy the contents of this range into the provided array.
    * @param destination Copy to this array
    * @param destinationOffset First index in the destination array.
-   * @return void to avoid confusion between which ByteRange should be returned
    */
   public void deepCopyTo(byte[] destination, int destinationOffset) {
     System.arraycopy(bytes, offset, destination, destinationOffset, length);
@@ -174,7 +173,6 @@ public class ByteRange implements Compar
    * @param copyLength Copy this many bytes
    * @param destination Copy to this array
    * @param destinationOffset First index in the destination array.
-   * @return void to avoid confusion between which ByteRange should be returned
    */
   public void deepCopySubRangeTo(int innerOffset, int copyLength, byte[] destination,
       int destinationOffset) {

Modified: hbase/trunk/hbase-common/src/main/java/org/apache/hbase/Cell.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-common/src/main/java/org/apache/hbase/Cell.java?rev=1422134&r1=1422133&r2=1422134&view=diff
==============================================================================
--- hbase/trunk/hbase-common/src/main/java/org/apache/hbase/Cell.java (original)
+++ hbase/trunk/hbase-common/src/main/java/org/apache/hbase/Cell.java Fri Dec 14 22:37:55
2012
@@ -46,7 +46,7 @@ import org.apache.hbase.cell.CellTool;
  * or debugging code. These should be placed in a sub-interface or the {@link CellTool} class.
  * <p/>
  * Cell implements Comparable<Cell> which is only meaningful when comparing to other
keys in the
- * same table. It uses {@link #CellComparator} which does not work on the -ROOT- and .META.
tables.
+ * same table. It uses CellComparator which does not work on the -ROOT- and .META. tables.
  * <p/>
  * In the future, we may consider adding a boolean isOnHeap() method and a getValueBuffer()
method
  * that can be used to pass a value directly from an off-heap ByteBuffer to the network without
@@ -133,7 +133,6 @@ public interface Cell {
   //5) Type
 
   /**
-   * see {@link #KeyValue.TYPE}
    * @return The byte representation of the KeyValue.TYPE of this cell: one of Put, Delete,
etc
    */
   byte getTypeByte();

Modified: hbase/trunk/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceFactory.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceFactory.java?rev=1422134&r1=1422133&r2=1422134&view=diff
==============================================================================
--- hbase/trunk/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceFactory.java
(original)
+++ hbase/trunk/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceFactory.java
Fri Dec 14 22:37:55 2012
@@ -35,7 +35,7 @@ public interface MetricsRegionServerSour
    * Create a MetricsRegionSource from a MetricsRegionWrapper.
    *
    * @param wrapper
-   * @return
+   * @return A metrics region source
    */
   MetricsRegionSource createRegion(MetricsRegionWrapper wrapper);
 }

Modified: hbase/trunk/hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/mapreduce/JobUtil.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/mapreduce/JobUtil.java?rev=1422134&r1=1422133&r2=1422134&view=diff
==============================================================================
--- hbase/trunk/hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/mapreduce/JobUtil.java
(original)
+++ hbase/trunk/hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/mapreduce/JobUtil.java
Fri Dec 14 22:37:55 2012
@@ -45,7 +45,7 @@ public abstract class JobUtil {
   /**
    * Initializes the staging directory and returns the path.
    *
-   * @parms conf system configuration
+   * @param conf system configuration
    * @return staging directory path
    * @throws IOException
    * @throws InterruptedException

Modified: hbase/trunk/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/mapreduce/JobUtil.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/mapreduce/JobUtil.java?rev=1422134&r1=1422133&r2=1422134&view=diff
==============================================================================
--- hbase/trunk/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/mapreduce/JobUtil.java
(original)
+++ hbase/trunk/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/mapreduce/JobUtil.java
Fri Dec 14 22:37:55 2012
@@ -44,7 +44,7 @@ public abstract class JobUtil {
   /**
    * Initializes the staging directory and returns the path.
    *
-   * @parms conf system configuration
+   * @param conf system configuration
    * @return staging directory path
    * @throws IOException
    * @throws InterruptedException

Modified: hbase/trunk/pom.xml
URL: http://svn.apache.org/viewvc/hbase/trunk/pom.xml?rev=1422134&r1=1422133&r2=1422134&view=diff
==============================================================================
--- hbase/trunk/pom.xml (original)
+++ hbase/trunk/pom.xml Fri Dec 14 22:37:55 2012
@@ -393,7 +393,7 @@
             <!--Pass -DskipJavadoc=true or -DskipJavadoc on command-line to skip javadoc
building-->
             <skip>${skipJavadoc}</skip>
             <docfilessubdirs>true</docfilessubdirs>
-            <excludePackageNames>org.apache.hadoop.hbase.protobuf.generated.*:org.apache.hadoop.hbase.thrift.generated:org.apache.hadoop.hbase.rest.generated</excludePackageNames>
+            <excludePackageNames>org.junit.*:org.apache.hadoop.metrics2.*:org.apache.hadoop.hbase.protobuf.generated.*:org.apache.hadoop.hbase.thrift.generated:org.apache.hadoop.hbase.rest.generated</excludePackageNames>
             <debug>true</debug>
             <maxmemory>2g</maxmemory>
             <verbose>true</verbose>



Mime
View raw message