Return-Path: X-Original-To: apmail-hbase-commits-archive@www.apache.org Delivered-To: apmail-hbase-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E473CDA22 for ; Tue, 25 Sep 2012 17:57:52 +0000 (UTC) Received: (qmail 25874 invoked by uid 500); 25 Sep 2012 17:57:52 -0000 Delivered-To: apmail-hbase-commits-archive@hbase.apache.org Received: (qmail 25838 invoked by uid 500); 25 Sep 2012 17:57:52 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 25831 invoked by uid 99); 25 Sep 2012 17:57:52 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Sep 2012 17:57:52 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Sep 2012 17:57:46 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 0A54A23888FE for ; Tue, 25 Sep 2012 17:57:02 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1390026 - in /hbase/trunk: dev-support/hbase_eclipse_formatter.xml src/docbkx/developer.xml src/docbkx/troubleshooting.xml Date: Tue, 25 Sep 2012 17:57:01 -0000 To: commits@hbase.apache.org From: stack@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20120925175702.0A54A23888FE@eris.apache.org> Author: stack Date: Tue Sep 25 17:57:01 2012 New Revision: 1390026 URL: http://svn.apache.org/viewvc?rev=1390026&view=rev Log: HBASE-5691 and HBASE-3678 New standard HBase code formatter AND Add Eclipse-based Apache Formatter to HBase Wiki Added: hbase/trunk/dev-support/hbase_eclipse_formatter.xml Modified: hbase/trunk/src/docbkx/developer.xml hbase/trunk/src/docbkx/troubleshooting.xml Added: hbase/trunk/dev-support/hbase_eclipse_formatter.xml URL: http://svn.apache.org/viewvc/hbase/trunk/dev-support/hbase_eclipse_formatter.xml?rev=1390026&view=auto ============================================================================== --- hbase/trunk/dev-support/hbase_eclipse_formatter.xml (added) +++ hbase/trunk/dev-support/hbase_eclipse_formatter.xml Tue Sep 25 17:57:01 2012 @@ -0,0 +1,291 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + Modified: hbase/trunk/src/docbkx/developer.xml URL: http://svn.apache.org/viewvc/hbase/trunk/src/docbkx/developer.xml?rev=1390026&r1=1390025&r2=1390026&view=diff ============================================================================== --- hbase/trunk/src/docbkx/developer.xml (original) +++ hbase/trunk/src/docbkx/developer.xml Tue Sep 25 17:57:01 2012 @@ -53,9 +53,24 @@ git clone git://git.apache.org/hbase.git Eclipse
Code Formatting - See HBASE-3678 Add Eclipse-based Apache Formatter to HBase Wiki - for an Eclipse formatter to help ensure your code conforms to HBase'y coding convention. - The issue includes instructions for loading the attached formatter. + Under the dev-support folder, you will find hbase_eclipse_formatter.xml. + We encourage you to have this formatter in place in eclipse when editing HBase code. To load it into eclipse: + +Go to Eclipse->Preferences... +In Preferences, Go to Java->Code Style->>Formatter +Import... hbase_eclipse_formatter.xml +Click Apply +Still in Preferences, Go to Java->Editor->Save Actions +Check the following: + +Perform the selected actions on save +Format source code +Format edited lines + + +Click Apply + + In addition to the automatic formatting, make sure you follow the style guidelines explained in Also, no @author tags - that's a rule. Quality Javadoc comments are appreciated. And include the Apache license.
Modified: hbase/trunk/src/docbkx/troubleshooting.xml URL: http://svn.apache.org/viewvc/hbase/trunk/src/docbkx/troubleshooting.xml?rev=1390026&r1=1390025&r2=1390026&view=diff ============================================================================== --- hbase/trunk/src/docbkx/troubleshooting.xml (original) +++ hbase/trunk/src/docbkx/troubleshooting.xml Tue Sep 25 17:57:01 2012 @@ -1073,6 +1073,7 @@ attribute to Maven (See Case Studies