hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mbau...@apache.org
Subject svn commit: r1381162 - /hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
Date Wed, 05 Sep 2012 12:50:19 GMT
Author: mbautin
Date: Wed Sep  5 12:50:19 2012
New Revision: 1381162

URL: http://svn.apache.org/viewvc?rev=1381162&view=rev
[0.89-fb] [master] Remove region's last flushed sequence id _after_ closing

Author: avf

When we close a region during normal operation, we flush this region's memstore,
updating last flushed sequence id. This means last flushed sequence id continues
to be reported along with the rest of HServerInfo.

This revision removes the last flushed sequence id _after_ the region
is closed to handle this scenario correctly.

Test Plan:
Test on DL cluster: gracefully move a region from one node to another and
verify that the "last flushed sequence id that is less" is no longer printed.

Revert Plan:

Reviewers: kannan, aaiyer

Reviewed By: kannan

CC: hbase-eng@

Differential Revision: https://phabricator.fb.com/D565614

Task ID: 1426639


Modified: hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java?rev=1381162&r1=1381161&r2=1381162&view=diff
--- hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
+++ hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
Wed Sep  5 12:50:19 2012
@@ -2060,6 +2060,7 @@ public class HRegionServer implements HR
         throw e;
+      serverInfo.getFlushedSequenceIdByRegion().remove(hri.getRegionName());
       ClosedRegionInfo info =
         new ClosedRegionInfo(hri.getRegionNameAsString(), EnvironmentEdgeManager.currentTimeMillis()
                              hri.getStartKey(), hri.getEndKey());

View raw message