Return-Path: X-Original-To: apmail-hbase-commits-archive@www.apache.org Delivered-To: apmail-hbase-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A23D7D69C for ; Wed, 4 Jul 2012 15:12:05 +0000 (UTC) Received: (qmail 50590 invoked by uid 500); 4 Jul 2012 15:12:05 -0000 Delivered-To: apmail-hbase-commits-archive@hbase.apache.org Received: (qmail 50535 invoked by uid 500); 4 Jul 2012 15:12:05 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 50462 invoked by uid 99); 4 Jul 2012 15:12:04 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jul 2012 15:12:04 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jul 2012 15:11:58 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 4607523888D2 for ; Wed, 4 Jul 2012 15:11:39 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1357299 - in /hbase/branches/0.94/src: main/java/org/apache/hadoop/hbase/client/HTablePool.java test/java/org/apache/hadoop/hbase/client/TestHTablePool.java Date: Wed, 04 Jul 2012 15:11:39 -0000 To: commits@hbase.apache.org From: stack@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20120704151139.4607523888D2@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: stack Date: Wed Jul 4 15:11:38 2012 New Revision: 1357299 URL: http://svn.apache.org/viewvc?rev=1357299&view=rev Log: HBASE-6322 Unnecessary creation of finalizers in HTablePool; REVERT -- DOESN'T BELONG ON THIS BRANCH Modified: hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestHTablePool.java Modified: hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java URL: http://svn.apache.org/viewvc/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java?rev=1357299&r1=1357298&r2=1357299&view=diff ============================================================================== --- hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java (original) +++ hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java Wed Jul 4 15:11:38 2012 @@ -320,11 +320,12 @@ public class HTablePool implements Close * wrapped table back to the table pool * */ - class PooledHTable implements HTableInterface { + class PooledHTable extends HTable { private HTableInterface table; // actual table implementation public PooledHTable(HTableInterface table) throws IOException { + super(table.getConfiguration(), table.getTableName()); this.table = table; } Modified: hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestHTablePool.java URL: http://svn.apache.org/viewvc/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestHTablePool.java?rev=1357299&r1=1357298&r2=1357299&view=diff ============================================================================== --- hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestHTablePool.java (original) +++ hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestHTablePool.java Wed Jul 4 15:11:38 2012 @@ -183,6 +183,22 @@ public class TestHTablePool { Assert.assertTrue("alien table rejected", true); } } + + @Test + public void testClassCastException() { + //this test makes sure that client code that + //casts the table it got from pool to HTable won't break + HTablePool pool = new HTablePool(TEST_UTIL.getConfiguration(), + Integer.MAX_VALUE); + String tableName = Bytes.toString(TABLENAME); + try { + // get table and check if type is HTable + HTable table = (HTable) pool.getTable(tableName); + Assert.assertTrue("return type is HTable as expected", true); + } catch (ClassCastException e) { + Assert.fail("return type is not HTable"); + } + } } @Category(MediumTests.class)