hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mbau...@apache.org
Subject svn commit: r1333194 - /hbase/branches/0.89-fb/bin/hbase-config.sh
Date Wed, 02 May 2012 20:51:36 GMT
Author: mbautin
Date: Wed May  2 20:51:36 2012
New Revision: 1333194

URL: http://svn.apache.org/viewvc?rev=1333194&view=rev
Log:
[jira] [HBASE-5879] [89-fb] Enable JMX metrics collection for the Thrift proxy

Author: mbautin

Summary: We need to enable JMX on the Thrift proxy on a separate port different
from the JMX port used by regionserver. This is necessary for metrics
collection.

Test Plan:
- Deploy to dev cluster.
- Verify that it is possible to collect metrics through JMX from the Thrift
proxy.

Reviewers: kannan, liyintang, schen, tedyu

Reviewed By: kannan

Differential Revision: https://reviews.facebook.net/D2955

Modified:
    hbase/branches/0.89-fb/bin/hbase-config.sh

Modified: hbase/branches/0.89-fb/bin/hbase-config.sh
URL: http://svn.apache.org/viewvc/hbase/branches/0.89-fb/bin/hbase-config.sh?rev=1333194&r1=1333193&r2=1333194&view=diff
==============================================================================
--- hbase/branches/0.89-fb/bin/hbase-config.sh (original)
+++ hbase/branches/0.89-fb/bin/hbase-config.sh Wed May  2 20:51:36 2012
@@ -129,6 +129,10 @@ if [ -z "$HBASE_ZOOKEEPER_JMX_OPTS" ]; t
   HBASE_ZOOKEEPER_JMX_OPTS="$HBASE_JMX_OPTS -Dcom.sun.management.jmxremote.port=8092"
 fi
 
+if [ -z "$HBASE_THRIFT_JMX_OPTS" ]; then
+  HBASE_THRIFT_JMX_OPTS="$HBASE_JMX_OPTS -Dcom.sun.management.jmxremote.port=8093"
+fi
+
 # YourKit Java Profiling
 # Note that you need to have yjpagent.so & yjp.jar on your computer and have
 # LD_LIBRARY_PATH entry to their dir location. for example:
@@ -166,4 +170,8 @@ if [ -z "$HBASE_ZOOKEEPER_OPTS" ]; then
   export HBASE_ZOOKEEPER_OPTS="$HBASE_ZOOKEEPER_DBG_OPTS $HBASE_ZOOKEEPER_JMX_OPTS"
 fi
 
+if [ -z "$HBASE_THRIFT_OPTS" ]; then
+  export HBASE_THRIFT_OPTS="$HBASE_THRIFT_JMX_OPTS"
+fi
+
 export HBASE_SLAVE_TIMEOUT=300



Mime
View raw message