Return-Path: X-Original-To: apmail-hbase-commits-archive@www.apache.org Delivered-To: apmail-hbase-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 54E6C925D for ; Wed, 18 Apr 2012 21:22:01 +0000 (UTC) Received: (qmail 63950 invoked by uid 500); 18 Apr 2012 21:22:01 -0000 Delivered-To: apmail-hbase-commits-archive@hbase.apache.org Received: (qmail 63903 invoked by uid 500); 18 Apr 2012 21:22:01 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 63896 invoked by uid 99); 18 Apr 2012 21:22:01 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Apr 2012 21:22:01 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Apr 2012 21:21:58 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id AD2A623889E0 for ; Wed, 18 Apr 2012 21:21:37 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1327686 - in /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal: HLogPerformanceEvaluation.java TestHLog.java Date: Wed, 18 Apr 2012 21:21:37 -0000 To: commits@hbase.apache.org From: stack@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20120418212137.AD2A623889E0@eris.apache.org> Author: stack Date: Wed Apr 18 21:21:37 2012 New Revision: 1327686 URL: http://svn.apache.org/viewvc?rev=1327686&view=rev Log: HBASE-5825 TestHLog not running any tests; fix Modified: hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java Modified: hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java URL: http://svn.apache.org/viewvc/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java?rev=1327686&r1=1327685&r2=1327686&view=diff ============================================================================== --- hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java (original) +++ hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java Wed Apr 18 21:21:37 2012 @@ -348,8 +348,18 @@ public final class HLogPerformanceEvalua return(endTime - startTime); } + /** + * The guts of the {@link #main} method. + * Call this method to avoid the {@link #main(String[])} System.exit. + * @param args + * @return errCode + * @throws Exception + */ + static int innerMain(final String [] args) throws Exception { + return ToolRunner.run(HBaseConfiguration.create(), new HLogPerformanceEvaluation(), args); + } + public static void main(String[] args) throws Exception { - int exitCode = ToolRunner.run(HBaseConfiguration.create(), new HLogPerformanceEvaluation(), args); - System.exit(exitCode); + System.exit(innerMain(args)); } -} +} \ No newline at end of file Modified: hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java URL: http://svn.apache.org/viewvc/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java?rev=1327686&r1=1327685&r2=1327686&view=diff ============================================================================== --- hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java (original) +++ hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java Wed Apr 18 21:21:37 2012 @@ -142,7 +142,9 @@ public class TestHLog { // Run the HPE tool with three threads writing 3000 edits each concurrently. // When done, verify that all edits were written and that the order in the // WALs is of ascending edit sequence ids. - HLogPerformanceEvaluation.main(new String [] {"-threads", "3", "-verify", "-iterations", "3000"}); + int errCode = + HLogPerformanceEvaluation.innerMain(new String [] {"-threads", "3", "-verify", "-iterations", "3000"}); + assertEquals(0, errCode); } /**