Return-Path: X-Original-To: apmail-hbase-commits-archive@www.apache.org Delivered-To: apmail-hbase-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ED403960B for ; Mon, 12 Mar 2012 21:50:00 +0000 (UTC) Received: (qmail 16703 invoked by uid 500); 12 Mar 2012 21:50:00 -0000 Delivered-To: apmail-hbase-commits-archive@hbase.apache.org Received: (qmail 16670 invoked by uid 500); 12 Mar 2012 21:50:00 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 16662 invoked by uid 99); 12 Mar 2012 21:50:00 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Mar 2012 21:50:00 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Mar 2012 21:49:58 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id DFD4D2388847 for ; Mon, 12 Mar 2012 21:49:37 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1299892 - /hbase/trunk/dev-support/test-patch.sh Date: Mon, 12 Mar 2012 21:49:37 -0000 To: commits@hbase.apache.org From: stack@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20120312214937.DFD4D2388847@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: stack Date: Mon Mar 12 21:49:37 2012 New Revision: 1299892 URL: http://svn.apache.org/viewvc?rev=1299892&view=rev Log: HBASE-5567 test-patch.sh has logic error in findbugs check Modified: hbase/trunk/dev-support/test-patch.sh Modified: hbase/trunk/dev-support/test-patch.sh URL: http://svn.apache.org/viewvc/hbase/trunk/dev-support/test-patch.sh?rev=1299892&r1=1299891&r2=1299892&view=diff ============================================================================== --- hbase/trunk/dev-support/test-patch.sh (original) +++ hbase/trunk/dev-support/test-patch.sh Mon Mar 12 21:49:37 2012 @@ -545,7 +545,7 @@ $JIRA_COMMENT_FOOTER" done ### if current warnings greater than OK_FINDBUGS_WARNINGS - if [[ $findbugsWarnings > $OK_FINDBUGS_WARNINGS ]] ; then + if [[ $findbugsWarnings -gt $OK_FINDBUGS_WARNINGS ]] ; then JIRA_COMMENT="$JIRA_COMMENT -1 findbugs. The patch appears to introduce `expr $(($findbugsWarnings-$OK_FINDBUGS_WARNINGS))` new Findbugs (version ${findbugs_version}) warnings."