hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nspiegelb...@apache.org
Subject svn commit: r1233727 - /hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
Date Fri, 20 Jan 2012 02:22:44 GMT
Author: nspiegelberg
Date: Fri Jan 20 02:22:43 2012
New Revision: 1233727

URL: http://svn.apache.org/viewvc?rev=1233727&view=rev
Log:
[master] Fix wrong metrics for increment operation

Summary:
Fix wrong metrics for increment operation by using correct Bytes.toString
function.
It needs to back port to Saturn branch.

Test Plan: mvn test

Reviewers: kannan, mbautin

Reviewed By: mbautin

CC: hbase-eng@lists, mbautin

Differential Revision: https://phabricator.fb.com/D386938

Modified:
    hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java

Modified: hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java?rev=1233727&r1=1233726&r2=1233727&view=diff
==============================================================================
--- hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
(original)
+++ hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
Fri Jan 20 02:22:43 2012
@@ -3668,8 +3668,8 @@ public class HRegion implements HeapSize
     // do after lock
     long after = EnvironmentEdgeManager.currentTimeMillis();
     String signature = SchemaMetrics.generateSchemaMetricsPrefix(
-        this.getTableDesc().getNameAsString(), family.toString());
-    HRegion.incrTimeVaryingMetric(signature + ".increment_", after - before);
+        this.getTableDesc().getNameAsString(), Bytes.toString(family));
+		HRegion.incrTimeVaryingMetric(signature + ".increment_", after - before);
 
     if (flush) {
       // Request a cache flush.  Do it outside update lock.



Mime
View raw message