hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nspiegelb...@apache.org
Subject svn commit: r1232730 - /hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/master/ProcessServerShutdown.java
Date Wed, 18 Jan 2012 03:07:09 GMT
Author: nspiegelberg
Date: Wed Jan 18 03:07:09 2012
New Revision: 1232730

URL: http://svn.apache.org/viewvc?rev=1232730&view=rev
[master] Reset the status of the dead server's log splitting if the split
operation was failed.

There is a bug in the previous code.
When the master failed to split the dead server's log, it would retry this
operation later.
So the master should to reset the status of split log as NOT_RUNNING from
FAILED in order to retry to split that dead server' log again.

Test Plan: Running all the unit tests.

Reviewers: pkhemani, kannan, mbautin

Reviewed By: pkhemani

CC: hbase-eng@lists, pkhemani, liyintang

Differential Revision: https://phabricator.fb.com/D382992


Modified: hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/master/ProcessServerShutdown.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/master/ProcessServerShutdown.java?rev=1232730&r1=1232729&r2=1232730&view=diff
--- hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/master/ProcessServerShutdown.java
+++ hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/master/ProcessServerShutdown.java
Wed Jan 18 03:07:09 2012
@@ -319,8 +319,9 @@ class ProcessServerShutdown extends Regi
     case FAILED:
-      LOG.warn("Failed splitting log for dead server " + deadServer);
-      return RegionServerOperationResult.OPERATION_FAILED;
+      logSplitResult = LogSplitResult.NOT_RUNNING;
+      throw new IOException("Failed splitting log for dead server " +
+				deadServer);
       throw new RuntimeException("Invalid split log result: "

View raw message