hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nspiegelb...@apache.org
Subject svn commit: r1227402 - /hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
Date Wed, 04 Jan 2012 23:46:55 GMT
Author: nspiegelberg
Date: Wed Jan  4 23:46:54 2012
New Revision: 1227402

URL: http://svn.apache.org/viewvc?rev=1227402&view=rev
Log:
[master] increase the number of sleep in TestZooKeeper

Summary:
The TestZooKeeper still will be failed in a nondeterministic way.
The daily build fails this unit test twice in the last 4 days.

So this diff is to increase the the number of sleep to reduce to the
possibility of test failure.

Test Plan: TestZooKeeper continuously.

Reviewers: kannan

Reviewed By: kannan

CC: hbase-eng@lists, kannan

Differential Revision: 380216

Modified:
    hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java

Modified: hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java?rev=1227402&r1=1227401&r2=1227402&view=diff
==============================================================================
--- hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
(original)
+++ hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
Wed Jan  4 23:46:54 2012
@@ -839,15 +839,16 @@ public class HBaseTestingUtility {
     int sessionTimeout = nodeZK.getSessionTimeout();
     byte[] password = nodeZK.getSessionPassword();
     long sessionID = nodeZK.getSessionID();
+    final long sleep = sessionTimeout * 10L;
+    final int maxRetryNum = 10;
+    int retryNum = maxRetryNum;
 
     ZooKeeper zk = new ZooKeeper(quorumServers,
         sessionTimeout, EmptyWatcher.instance, sessionID, password);
     zk.close();
+    Thread.sleep(sleep);
 		LOG.debug("ZooKeeper is closed");
 
-    final long sleep = sessionTimeout * 10L;
-    final int maxRetryNum = 10;
-    int retryNum = maxRetryNum;
     while (!nodeZK.isAborted() && retryNum != 0) {
       Thread.sleep(sleep);
       retryNum--;



Mime
View raw message