hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nspiegelb...@apache.org
Subject svn commit: r1202985 - /hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/TestMultiClusters.java
Date Thu, 17 Nov 2011 01:45:26 GMT
Author: nspiegelberg
Date: Thu Nov 17 01:45:25 2011
New Revision: 1202985

URL: http://svn.apache.org/viewvc?rev=1202985&view=rev
Log:
Fix TestMultiClusters when a non-default ZK client port is used

Summary: MiniZooKeeperCluster tries to use port 21810 as the client port but
keeps incrementing the port number if it fails to bind. However, the non-default
port is not communicated correctly to the second cluster's configuration in
TestMultiCluster.

Test Plan: Run all unit tests on titanmigrate002-snc4 using mrunit. Look for
log message "Faild [sic] binding ZK Server to client port: 21810" that confirms
that the port was likely taken by another concurrent test, so the mini ZK
cluster had to use another port.

Reviewers: liyintang, kannan, kranganathan

Reviewed By: kranganathan

CC: hbase-eng@lists, kranganathan

Differential Revision: 355266

Revert Plan: OK

Modified:
    hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/TestMultiClusters.java

Modified: hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/TestMultiClusters.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/TestMultiClusters.java?rev=1202985&r1=1202984&r2=1202985&view=diff
==============================================================================
--- hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/TestMultiClusters.java (original)
+++ hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/TestMultiClusters.java Thu
Nov 17 01:45:25 2011
@@ -57,6 +57,8 @@ public class TestMultiClusters {
 
     Configuration conf2 = HBaseConfiguration.create();
     conf2.set(HConstants.ZOOKEEPER_ZNODE_PARENT, "/2");
+    conf2.set("hbase.zookeeper.property.clientPort",
+        conf1.get("hbase.zookeeper.property.clientPort"));
     HBaseTestingUtility utility2 = new HBaseTestingUtility(conf2);
     // They share the same ensemble, but homed differently
     utility2.setZkCluster(utility1.getZkCluster());



Mime
View raw message