Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r1181959 -
 /hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java
Date: Tue, 11 Oct 2011 17:44:21 -0000
To: commits@hbase.apache.org
From: nspiegelberg@apache.org
Message-Id: <20111011174421.46EA72388C6C@eris.apache.org>

Author: nspiegelberg
Date: Tue Oct 11 17:44:20 2011
New Revision: 1181959

URL: http://svn.apache.org/viewvc?rev=1181959&view=rev
Log:
Fix out of bounds error in MultiPut portion of HBaseRPC's logResponse

Summary: D288291 introduced an off-by-one error in an array index. Thanks to
Mikhail for finding this.

Test Plan: Compiled and ran on dev server.

Reviewers: mbautin

Reviewed By: mbautin

CC: hbase@lists, mbautin

Differential Revision: 315114

Blame Revision: D288291

Modified:
    hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java

Modified: hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java?rev=1181959&r1=1181958&r2=1181959&view=diff
==============================================================================
--- hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java (original)
+++ hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java Tue Oct 11 17:44:20 2011
@@ -702,7 +702,7 @@ public class HBaseRPC {
       } else if (params.length == 1 && instance instanceof HRegionServer &&
           params[0] instanceof Operation) {
         // annotate the response map with operation details
-        responseInfo.putAll(((Operation) params[1]).toMap());
+        responseInfo.putAll(((Operation) params[0]).toMap());
         // report to the log file
         LOG.warn("(operation" + tag + "): " +
             mapper.writeValueAsString(responseInfo));