hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@apache.org
Subject svn commit: r1084051 - in /hbase/trunk: CHANGES.txt src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
Date Tue, 22 Mar 2011 02:04:01 GMT
Author: stack
Date: Tue Mar 22 02:04:01 2011
New Revision: 1084051

URL: http://svn.apache.org/viewvc?rev=1084051&view=rev
Log:
HBASE-3674 Treat ChecksumException as we would a ParseException splitting logs; else we replay
split on every restart

Modified:
    hbase/trunk/CHANGES.txt
    hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java

Modified: hbase/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hbase/trunk/CHANGES.txt?rev=1084051&r1=1084050&r2=1084051&view=diff
==============================================================================
--- hbase/trunk/CHANGES.txt (original)
+++ hbase/trunk/CHANGES.txt Tue Mar 22 02:04:01 2011
@@ -153,6 +153,8 @@ Release 0.90.2 - Unreleased
    HBASE-3664  [replication] Adding a slave when there's none may kill the cluster
    HBASE-3671  Split report before we finish parent region open; workaround
                till 0.92; Race between split and OPENED processing
+   HBASE-3674  Treat ChecksumException as we would a ParseException splitting
+               logs; else we replay split on every restart
 
   IMPROVEMENTS
    HBASE-3542  MultiGet methods in Thrift

Modified: hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
URL: http://svn.apache.org/viewvc/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java?rev=1084051&r1=1084050&r2=1084051&view=diff
==============================================================================
--- hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java (original)
+++ hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java Tue
Mar 22 02:04:01 2011
@@ -243,7 +243,7 @@ public class HLogSplitter {
     List<Path> corruptedLogs = new ArrayList<Path>();
     List<Path> splits = null;
 
-    boolean skipErrors = conf.getBoolean("hbase.hlog.split.skip.errors", false);
+    boolean skipErrors = conf.getBoolean("hbase.hlog.split.skip.errors", true);
 
     splitSize = 0;
 
@@ -276,7 +276,7 @@ public class HLogSplitter {
           // If the IOE resulted from bad file format,
           // then this problem is idempotent and retrying won't help
           if (e.getCause() instanceof ParseException) {
-            LOG.warn("ParseException from hlog " + logPath + ".  continuing");
+            LOG.warn("Parse exception from hlog " + logPath + ".  continuing", e);
             processedLogs.add(logPath);
           } else {
             if (skipErrors) {



Mime
View raw message