Return-Path: Delivered-To: apmail-hbase-commits-archive@www.apache.org Received: (qmail 27522 invoked from network); 4 Feb 2011 17:36:16 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 4 Feb 2011 17:36:16 -0000 Received: (qmail 59119 invoked by uid 500); 4 Feb 2011 17:36:16 -0000 Delivered-To: apmail-hbase-commits-archive@hbase.apache.org Received: (qmail 59022 invoked by uid 500); 4 Feb 2011 17:36:14 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 58921 invoked by uid 99); 4 Feb 2011 17:36:14 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Feb 2011 17:36:14 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Feb 2011 17:36:12 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 5AF1F2388A44; Fri, 4 Feb 2011 17:35:51 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1067235 - /hbase/trunk/src/test/java/org/apache/hadoop/hbase/filter/TestRandomRowFilter.java Date: Fri, 04 Feb 2011 17:35:51 -0000 To: commits@hbase.apache.org From: apurtell@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20110204173551.5AF1F2388A44@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: apurtell Date: Fri Feb 4 17:35:51 2011 New Revision: 1067235 URL: http://svn.apache.org/viewvc?rev=1067235&view=rev Log: HBASE-2824 A filter that randomly includes rows based on a configured chance; Clarify test Modified: hbase/trunk/src/test/java/org/apache/hadoop/hbase/filter/TestRandomRowFilter.java Modified: hbase/trunk/src/test/java/org/apache/hadoop/hbase/filter/TestRandomRowFilter.java URL: http://svn.apache.org/viewvc/hbase/trunk/src/test/java/org/apache/hadoop/hbase/filter/TestRandomRowFilter.java?rev=1067235&r1=1067234&r2=1067235&view=diff ============================================================================== --- hbase/trunk/src/test/java/org/apache/hadoop/hbase/filter/TestRandomRowFilter.java (original) +++ hbase/trunk/src/test/java/org/apache/hadoop/hbase/filter/TestRandomRowFilter.java Fri Feb 4 17:35:51 2011 @@ -30,12 +30,12 @@ import junit.framework.TestCase; import org.apache.hadoop.hbase.util.Bytes; public class TestRandomRowFilter extends TestCase { - protected RandomRowFilter halfChanceFilter; + protected RandomRowFilter quarterChanceFilter; @Override protected void setUp() throws Exception { super.setUp(); - halfChanceFilter = new RandomRowFilter(0.25f); + quarterChanceFilter = new RandomRowFilter(0.25f); } /** @@ -47,7 +47,7 @@ public class TestRandomRowFilter extends int included = 0; int max = 1000000; for (int i = 0; i < max; i++) { - if (!halfChanceFilter.filterRowKey(Bytes.toBytes("row"), 0, Bytes + if (!quarterChanceFilter.filterRowKey(Bytes.toBytes("row"), 0, Bytes .toBytes("row").length)) { included++; } @@ -66,10 +66,10 @@ public class TestRandomRowFilter extends * @throws Exception */ public void testSerialization() throws Exception { - RandomRowFilter newFilter = serializationTest(halfChanceFilter); + RandomRowFilter newFilter = serializationTest(quarterChanceFilter); // use epsilon float comparison assertTrue("float should be equal", Math.abs(newFilter.getChance() - - halfChanceFilter.getChance()) < 0.000001f); + - quarterChanceFilter.getChance()) < 0.000001f); } private RandomRowFilter serializationTest(RandomRowFilter filter)