Return-Path: Delivered-To: apmail-hbase-commits-archive@www.apache.org Received: (qmail 50604 invoked from network); 24 Nov 2010 18:20:48 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 24 Nov 2010 18:20:48 -0000 Received: (qmail 69849 invoked by uid 500); 24 Nov 2010 18:21:20 -0000 Delivered-To: apmail-hbase-commits-archive@hbase.apache.org Received: (qmail 69814 invoked by uid 500); 24 Nov 2010 18:21:20 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 69807 invoked by uid 99); 24 Nov 2010 18:21:20 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Nov 2010 18:21:20 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Nov 2010 18:21:17 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 7CB40238890D; Wed, 24 Nov 2010 18:19:44 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1038745 - in /hbase/branches/0.90: ./ src/docbkx/ src/main/java/org/apache/hadoop/hbase/master/ src/main/java/org/apache/hadoop/hbase/zookeeper/ src/main/resources/ Date: Wed, 24 Nov 2010 18:19:44 -0000 To: commits@hbase.apache.org From: jdcryans@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20101124181944.7CB40238890D@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: jdcryans Date: Wed Nov 24 18:19:43 2010 New Revision: 1038745 URL: http://svn.apache.org/viewvc?rev=1038745&view=rev Log: HBASE-3273 Set the ZK default timeout to 3 minutes Modified: hbase/branches/0.90/CHANGES.txt hbase/branches/0.90/src/docbkx/book.xml hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/master/HMaster.java hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java hbase/branches/0.90/src/main/resources/hbase-default.xml Modified: hbase/branches/0.90/CHANGES.txt URL: http://svn.apache.org/viewvc/hbase/branches/0.90/CHANGES.txt?rev=1038745&r1=1038744&r2=1038745&view=diff ============================================================================== --- hbase/branches/0.90/CHANGES.txt (original) +++ hbase/branches/0.90/CHANGES.txt Wed Nov 24 18:19:43 2010 @@ -1175,6 +1175,7 @@ Release 0.90.0 - Unreleased HBASE-3230 Refresh our hadoop jar and update zookeeper to just-released 3.3.2 HBASE-3231 Update to zookeeper 3.3.2. + HBASE-3273 Set the ZK default timeout to 3 minutes NEW FEATURES Modified: hbase/branches/0.90/src/docbkx/book.xml URL: http://svn.apache.org/viewvc/hbase/branches/0.90/src/docbkx/book.xml?rev=1038745&r1=1038744&r2=1038745&view=diff ============================================================================== --- hbase/branches/0.90/src/docbkx/book.xml (original) +++ hbase/branches/0.90/src/docbkx/book.xml Wed Nov 24 18:19:43 2010 @@ -299,7 +299,10 @@ Usually you'll want to use the latest ve in branch-0.20-append to see list of patches involved. HBase bundles the Apache branch-0.20-append Hadoop. Replace the Hadoop jar bundled with HBase with that you have - installed on your cluster to avoid version mismatch issues. + installed on your cluster to avoid version mismatch issues; + for example, versions of CDH do not have HDFS-724 whereas + Hadoops branch-0.20-append branch does have HDFS-724. This + patch changes the RPC version because protocol was changed.
ssh @@ -984,6 +987,28 @@ to ensure well-formedness of your docume
Recommended Configuations +
<varname>zookeeper.session.timeout</varname> + The default timeout is three minutes (specified in milliseconds). This means + that if a server crashes, it will be three minutes before the Master notices + the crash and starts recovery. You might like to tune the timeout down to + a minute or even less so the Master notices failures the sooner. + Before changing this value, be sure you have your JVM garbage collection + configuration under control otherwise, a long garbage collection that lasts + beyond the zookeeper session timeout will take out + your RegionServer (You might be fine with this -- you probably want recovery to start + on the server if a RegionServer has been in GC for a long period of time). + + To change this configuration, edit hbase-site.xml, + copy the changed file around the cluster and restart. + + We set this value high to save our having to field noob questions up on the mailing lists asking + why a RegionServer went down during a massive import. The usual cause is that their JVM is untuned and + they are running into long GC pauses. Our thinking is that + while users are getting familiar with HBase, we'd save them having to know all of its + intricacies. Later when they've built some confidence, then they can play + with configuration such as this. + +
Configuration for large memory machines Modified: hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/master/HMaster.java URL: http://svn.apache.org/viewvc/hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/master/HMaster.java?rev=1038745&r1=1038744&r2=1038745&view=diff ============================================================================== --- hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/master/HMaster.java (original) +++ hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/master/HMaster.java Wed Nov 24 18:19:43 2010 @@ -238,7 +238,7 @@ implements HMasterInterface, HMasterRegi while (!amm.isActiveMaster()) { LOG.debug("Waiting for master address ZNode to be written " + "(Also watching cluster state node)"); - Thread.sleep(c.getInt("zookeeper.session.timeout", 60 * 1000)); + Thread.sleep(c.getInt("zookeeper.session.timeout", 180 * 1000)); } } Modified: hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java URL: http://svn.apache.org/viewvc/hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java?rev=1038745&r1=1038744&r2=1038745&view=diff ============================================================================== --- hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java (original) +++ hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java Wed Nov 24 18:19:43 2010 @@ -121,7 +121,6 @@ public class HMasterCommandLine extends if (zkClientPort == 0) { throw new IOException("No config value for hbase.zookeeper.property.clientPort"); } - zooKeeperCluster.setTickTime(conf.getInt("hbase.zookeeper.property.tickTime", 3000)); zooKeeperCluster.setClientPort(zkClientPort); int clientPort = zooKeeperCluster.startup(zkDataPath); if (clientPort != zkClientPort) { Modified: hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java URL: http://svn.apache.org/viewvc/hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java?rev=1038745&r1=1038744&r2=1038745&view=diff ============================================================================== --- hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java (original) +++ hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java Wed Nov 24 18:19:43 2010 @@ -125,6 +125,10 @@ public class HQuorumPeer { } } + // Set the max session timeout from the provided client-side timeout + properties.setProperty("maxSessionTimeout", + conf.get("zookeeper.session.timeout", "180000")); + if (myId == -1) { throw new IOException("Could not find my address: " + myAddress + " in list of ZooKeeper quorum servers"); Modified: hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java URL: http://svn.apache.org/viewvc/hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java?rev=1038745&r1=1038744&r2=1038745&view=diff ============================================================================== --- hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java (original) +++ hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java Wed Nov 24 18:19:43 2010 @@ -91,7 +91,7 @@ public class ZKUtil { if(ensemble == null) { throw new IOException("Unable to determine ZooKeeper ensemble"); } - int timeout = conf.getInt("zookeeper.session.timeout", 60 * 1000); + int timeout = conf.getInt("zookeeper.session.timeout", 180 * 1000); LOG.debug(descriptor + " opening connection to ZooKeeper with ensemble (" + ensemble + ")"); return new ZooKeeper(ensemble, timeout, watcher); Modified: hbase/branches/0.90/src/main/resources/hbase-default.xml URL: http://svn.apache.org/viewvc/hbase/branches/0.90/src/main/resources/hbase-default.xml?rev=1038745&r1=1038744&r2=1038745&view=diff ============================================================================== --- hbase/branches/0.90/src/main/resources/hbase-default.xml (original) +++ hbase/branches/0.90/src/main/resources/hbase-default.xml Wed Nov 24 18:19:43 2010 @@ -444,7 +444,7 @@ zookeeper.session.timeout - 60000 + 180000 ZooKeeper session timeout. HBase passes this to the zk quorum as suggested maximum time for a session. See http://hadoop.apache.org/zookeeper/docs/current/zookeeperProgrammers.html#ch_zkSessions