hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@apache.org
Subject svn commit: r991741 - in /hbase/trunk: CHANGES.txt src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java
Date Wed, 01 Sep 2010 22:34:13 GMT
Author: stack
Date: Wed Sep  1 22:34:12 2010
New Revision: 991741

URL: http://svn.apache.org/viewvc?rev=991741&view=rev
Log:
HBASE-2918 SequenceFileLogWriter doesnt make it clear if there is no append by config or by
missing lib/feature

Modified:
    hbase/trunk/CHANGES.txt
    hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java

Modified: hbase/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hbase/trunk/CHANGES.txt?rev=991741&r1=991740&r2=991741&view=diff
==============================================================================
--- hbase/trunk/CHANGES.txt (original)
+++ hbase/trunk/CHANGES.txt Wed Sep  1 22:34:12 2010
@@ -496,6 +496,8 @@ Release 0.21.0 - Unreleased
    HBASE-2948  bin/hbase shell broken (after hbase-2692)
                (Sebastian Bauer via Stack)
    HBASE-2954  Fix broken build caused by hbase-2692 commit
+   HBASE-2918  SequenceFileLogWriter doesnt make it clear if there is no
+               append by config or by missing lib/feature
 
   IMPROVEMENTS
    HBASE-1760  Cleanup TODOs in HTable

Modified: hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java
URL: http://svn.apache.org/viewvc/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java?rev=991741&r1=991740&r2=991741&view=diff
==============================================================================
--- hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java
(original)
+++ hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java
Wed Sep  1 22:34:12 2010
@@ -91,7 +91,8 @@ public class SequenceFileLogWriter imple
     // Now do dirty work to see if syncFs is available.
     // Test if syncfs is available.
     Method m = null;
-    if (conf.getBoolean("dfs.support.append", false)) {
+    boolean append = conf.getBoolean("dfs.support.append", false);
+    if (append) {
       try {
         // function pointer to writer.syncFs()
         m = this.writer.getClass().getMethod("syncFs", new Class<?> []{});
@@ -103,7 +104,8 @@ public class SequenceFileLogWriter imple
     }
     this.syncFs = m;
     LOG.info((this.syncFs != null)?
-      "Using syncFs -- HDFS-200": "syncFs -- HDFS-200 -- not available");
+      "Using syncFs -- HDFS-200":
+      ("syncFs -- HDFS-200 -- not available, dfs.support.append=" + append));
   }
 
   @Override
@@ -140,4 +142,4 @@ public class SequenceFileLogWriter imple
   public OutputStream getDFSCOutputStream() {
     return this.dfsClient_out;
   }
-}
\ No newline at end of file
+}



Mime
View raw message