hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@apache.org
Subject svn commit: r931695 - in /hadoop/hbase/branches/0.20: CHANGES.txt src/java/org/apache/hadoop/hbase/regionserver/HRegion.java src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
Date Wed, 07 Apr 2010 21:33:11 GMT
Author: stack
Date: Wed Apr  7 21:33:10 2010
New Revision: 931695

URL: http://svn.apache.org/viewvc?rev=931695&view=rev
Log:
HBASE-2419 Remove from RS logs the fat NotServingRegionException stack

Modified:
    hadoop/hbase/branches/0.20/CHANGES.txt
    hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/regionserver/HRegion.java
    hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java

Modified: hadoop/hbase/branches/0.20/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hbase/branches/0.20/CHANGES.txt?rev=931695&r1=931694&r2=931695&view=diff
==============================================================================
--- hadoop/hbase/branches/0.20/CHANGES.txt (original)
+++ hadoop/hbase/branches/0.20/CHANGES.txt Wed Apr  7 21:33:10 2010
@@ -71,6 +71,7 @@ Release 0.20.4 - Unreleased
    HBASE-2398  NPE in HLog.append when calling writer.getLength
                (Kannan Muthukkaruppan via Stack)
    HBASE-2410  spurious warnings from util.Sleeper
+   HBASE-2419  Remove from RS logs the fat NotServingRegionException stack
 
   IMPROVEMENTS
    HBASE-2180  Bad read performance from synchronizing hfile.fddatainputstream

Modified: hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/regionserver/HRegion.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/regionserver/HRegion.java?rev=931695&r1=931694&r2=931695&view=diff
==============================================================================
--- hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/regionserver/HRegion.java
(original)
+++ hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/regionserver/HRegion.java
Wed Apr  7 21:33:10 2010
@@ -1711,7 +1711,7 @@ public class HRegion implements HConstan
     splitsAndClosesLock.readLock().lock();
     try {
       if (this.closed.get()) {
-        throw new NotServingRegionException("Region " + this + " closed");
+        throw new NotServingRegionException(this + " is closed");
       }
       synchronized (lockedRows) {
         while (lockedRows.contains(row)) {

Modified: hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java?rev=931695&r1=931694&r2=931695&view=diff
==============================================================================
--- hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
(original)
+++ hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
Wed Apr  7 21:33:10 2010
@@ -1495,7 +1495,7 @@ public class HRegionServer implements HC
                   + e.msg.toString());
             }
           } catch (InterruptedException ex) {
-            // continue
+            LOG.warn("Processing Worker queue", ex);
           } catch (Exception ex) {
             if (ex instanceof IOException) {
               ex = RemoteExceptionHandler.checkIOException((IOException) ex);
@@ -1764,7 +1764,6 @@ public class HRegionServer implements HC
         this.cacheFlusher.reclaimMemStoreMemory();
       }
       region.put(put, getLockFromId(put.getLockId()));
-      
     } catch (Throwable t) {
       throw convertThrowableToIOE(cleanup(t));
     }
@@ -1792,7 +1791,8 @@ public class HRegionServer implements HC
       LOG.debug("Batch puts: " + i, ex);
       return i;
     } catch (NotServingRegionException ex) {
-      LOG.debug("Batch puts: " + i, ex);
+      LOG.debug("Batch puts interrupted at index=" + i + " because:" +
+        ex.getMessage());
       return i;
     } catch (Throwable t) {
       throw convertThrowableToIOE(cleanup(t));
@@ -2534,5 +2534,4 @@ public class HRegionServer implements HC
 
     return resp;
   }
-
 }



Mime
View raw message