hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jdcry...@apache.org
Subject svn commit: r929192 - in /hadoop/hbase/branches/0.20: CHANGES.txt src/java/org/apache/hadoop/hbase/util/Sleeper.java
Date Tue, 30 Mar 2010 16:54:53 GMT
Author: jdcryans
Date: Tue Mar 30 16:54:52 2010
New Revision: 929192

URL: http://svn.apache.org/viewvc?rev=929192&view=rev
Log:
HBASE-2388  Give a very explicit message when we figure a big GC pause

Modified:
    hadoop/hbase/branches/0.20/CHANGES.txt
    hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/util/Sleeper.java

Modified: hadoop/hbase/branches/0.20/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hbase/branches/0.20/CHANGES.txt?rev=929192&r1=929191&r2=929192&view=diff
==============================================================================
--- hadoop/hbase/branches/0.20/CHANGES.txt (original)
+++ hadoop/hbase/branches/0.20/CHANGES.txt Tue Mar 30 16:54:52 2010
@@ -97,6 +97,7 @@ Release 0.20.4 - Unreleased
                INFO or WARN
    HBASE-2374  TableInputFormat - Configurable parameter to add column families
                (Kay Kay via Stack)
+   HBASE-2388  Give a very explicit message when we figure a big GC pause
 
   NEW FEATURES
    HBASE-2257  [stargate] multiuser mode

Modified: hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/util/Sleeper.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/util/Sleeper.java?rev=929192&r1=929191&r2=929192&view=diff
==============================================================================
--- hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/util/Sleeper.java (original)
+++ hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/util/Sleeper.java Tue Mar
30 16:54:52 2010
@@ -34,6 +34,7 @@ public class Sleeper {
   private final Log LOG = LogFactory.getLog(this.getClass().getName());
   private final int period;
   private AtomicBoolean stop;
+  private static final long TIME_FOR_WARNING = 30000;
   
   /**
    * @param sleep
@@ -74,9 +75,10 @@ public class Sleeper {
         Thread.sleep(waitTime);
         woke = System.currentTimeMillis();
         long slept = woke - now;
-        if (slept > (10 * this.period)) {
-          LOG.warn("We slept " + slept + "ms, ten times longer than scheduled: " +
-            this.period);
+        if (slept > TIME_FOR_WARNING) {
+          LOG.warn("We slept " + slept + "ms, this is likely due to a long " +
+              "garbage collecting pause and it's usually bad, " +
+              "see http://wiki.apache.org/hadoop/Hbase/Troubleshooting#A9");
         }
       } catch(InterruptedException iex) {
         // We we interrupted because we're meant to stop?  If not, just



Mime
View raw message