hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@apache.org
Subject svn commit: r919868 - in /hadoop/hbase/branches/0.20/src: java/org/apache/hadoop/hbase/filter/WhileMatchFilter.java test/org/apache/hadoop/hbase/filter/TestFilter.java
Date Sat, 06 Mar 2010 22:41:19 GMT
Author: stack
Date: Sat Mar  6 22:41:18 2010
New Revision: 919868

URL: http://svn.apache.org/viewvc?rev=919868&view=rev
Log:
HBASE-2261 The javadoc in WhileMatchFilter and it's tests in TestFilter are not accurate/wrong

Modified:
    hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/filter/WhileMatchFilter.java
    hadoop/hbase/branches/0.20/src/test/org/apache/hadoop/hbase/filter/TestFilter.java

Modified: hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/filter/WhileMatchFilter.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/filter/WhileMatchFilter.java?rev=919868&r1=919867&r2=919868&view=diff
==============================================================================
--- hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/filter/WhileMatchFilter.java
(original)
+++ hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/filter/WhileMatchFilter.java
Sat Mar  6 22:41:18 2010
@@ -27,11 +27,12 @@
 import java.io.DataInput;
 
 /**
- * A wrapper filter that filters everything after the first time false is returned
- * from any wrapped filters {@link Filter#filterRowKey(byte[], int, int)},
+ * A wrapper filter that returns true from {@link #filterAllRemaining()} as soon
+ * as the wrapped filters {@link Filter#filterRowKey(byte[], int, int)},
  * {@link Filter#filterKeyValue(org.apache.hadoop.hbase.KeyValue)},
  * {@link org.apache.hadoop.hbase.filter.Filter#filterRow()} or 
- * {@link org.apache.hadoop.hbase.filter.Filter#filterAllRemaining()}.
+ * {@link org.apache.hadoop.hbase.filter.Filter#filterAllRemaining()} methods
+ * returns true.
  */
 public class WhileMatchFilter implements Filter {
   private boolean filterAllRemaining = false;

Modified: hadoop/hbase/branches/0.20/src/test/org/apache/hadoop/hbase/filter/TestFilter.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/branches/0.20/src/test/org/apache/hadoop/hbase/filter/TestFilter.java?rev=919868&r1=919867&r2=919868&view=diff
==============================================================================
--- hadoop/hbase/branches/0.20/src/test/org/apache/hadoop/hbase/filter/TestFilter.java (original)
+++ hadoop/hbase/branches/0.20/src/test/org/apache/hadoop/hbase/filter/TestFilter.java Sat
Mar  6 22:41:18 2010
@@ -259,7 +259,7 @@
   /**
    * Tests the the {@link WhileMatchFilter} works in combination with a
    * {@link Filter} that uses the
-   * {@link PageFilter#filterRow()} method.
+   * {@link Filter#filterRow()} method.
    *
    * See HBASE-2258.
    *
@@ -291,7 +291,7 @@
   /**
    * Tests the the {@link WhileMatchFilter} works in combination with a
    * {@link Filter} that uses the
-   * {@link PageFilter#filterRowKey(byte[], int, int)} method.
+   * {@link Filter#filterRowKey(byte[], int, int)} method.
    *
    * See HBASE-2258.
    *
@@ -319,7 +319,7 @@
   /**
    * Tests the the {@link WhileMatchFilter} works in combination with a
    * {@link Filter} that uses the
-   * {@link PageFilter#filterKeyValue(org.apache.hadoop.hbase.KeyValue)} method.
+   * {@link Filter#filterKeyValue(org.apache.hadoop.hbase.KeyValue)} method.
    *
    * See HBASE-2258.
    *



Mime
View raw message