hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@apache.org
Subject svn commit: r918324 - /hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/master/BaseScanner.java
Date Wed, 03 Mar 2010 04:48:05 GMT
Author: stack
Date: Wed Mar  3 04:48:05 2010
New Revision: 918324

URL: http://svn.apache.org/viewvc?rev=918324&view=rev
Log:
 HBASE-2244  META gets inconsistent in a number of crash scenarios

Modified:
    hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/master/BaseScanner.java

Modified: hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/master/BaseScanner.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/master/BaseScanner.java?rev=918324&r1=918323&r2=918324&view=diff
==============================================================================
--- hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/master/BaseScanner.java (original)
+++ hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/master/BaseScanner.java Wed
Mar  3 04:48:05 2010
@@ -339,9 +339,8 @@
     if (!references) return references;
     if (!verifyDaughterRowPresent(rowContent, qualifier, srvr, metaRegionName,
         hri, parent)) {
-      // If we got here, we added a daughter region to metatable. Update
-      // parent row that daughter has been verified present so we don't check
-      // for it by doing a get each time through here.
+      // If we got here, then the parent row does not yet have the
+      // "daughter row verified present" marker present. Add it.
       addDaughterRowChecked(metaRegionName, srvr, parent.getRegionName(), hri,
         qualifier);
     }
@@ -357,8 +356,8 @@
    * @param metaRegionName
    * @param daughterHRI
    * @throws IOException
-   * @return True, if the daughter row is present in meta.  If false, this
-   * method just added it to meta.
+   * @return True, if parent row has marker for "daughter row verified present"
+   * else, false (and will do fixup adding daughter if daughter not present).
    */
   private boolean verifyDaughterRowPresent(final Result rowContent,
       final byte [] daughter, final HRegionInterface srvr,



Mime
View raw message