hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@apache.org
Subject svn commit: r793642 - in /hadoop/hbase/trunk: CHANGES.txt src/java/org/apache/hadoop/hbase/filter/ValueFilter.java
Date Mon, 13 Jul 2009 18:09:56 GMT
Author: stack
Date: Mon Jul 13 18:09:55 2009
New Revision: 793642

URL: http://svn.apache.org/viewvc?rev=793642&view=rev
Log:
HBASE-1649 ValueFilter may not reset its internal state

Modified:
    hadoop/hbase/trunk/CHANGES.txt
    hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/filter/ValueFilter.java

Modified: hadoop/hbase/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/CHANGES.txt?rev=793642&r1=793641&r2=793642&view=diff
==============================================================================
--- hadoop/hbase/trunk/CHANGES.txt (original)
+++ hadoop/hbase/trunk/CHANGES.txt Mon Jul 13 18:09:55 2009
@@ -258,6 +258,8 @@
                (Doğacan Güney via Stack)
    HBASE-1639  clean checkout with empty hbase-site.xml, zk won't start
    HBASE-1646  Scan-s can't set a Filter (Doğacan Güney via Stack)
+   HBASE-1649  ValueFilter may not reset its internal state
+               (Doğacan Güney via Stack)
 
   IMPROVEMENTS
    HBASE-1089  Add count of regions on filesystem to master UI; add percentage

Modified: hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/filter/ValueFilter.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/filter/ValueFilter.java?rev=793642&r1=793641&r2=793642&view=diff
==============================================================================
--- hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/filter/ValueFilter.java (original)
+++ hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/filter/ValueFilter.java Mon Jul 13
18:09:55 2009
@@ -194,14 +194,12 @@
   }
 
   public boolean filterRow() {
-    boolean result = filterThisRow || (filterIfColumnMissing && !foundColValue);
-    filterThisRow = false;
-    foundColValue = false;
-    return result;
+    return filterThisRow || (filterIfColumnMissing && !foundColValue);
   }
 
-  public void reset() {
-    // Nothing.
+  public void reset() {    
+    filterThisRow = false;
+    foundColValue = false;
   }
 
   public void readFields(final DataInput in) throws IOException {



Mime
View raw message