Return-Path: Delivered-To: apmail-hadoop-hbase-commits-archive@minotaur.apache.org Received: (qmail 67973 invoked from network); 30 Apr 2009 20:08:11 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 30 Apr 2009 20:08:11 -0000 Received: (qmail 46547 invoked by uid 500); 30 Apr 2009 20:08:11 -0000 Delivered-To: apmail-hadoop-hbase-commits-archive@hadoop.apache.org Received: (qmail 46524 invoked by uid 500); 30 Apr 2009 20:08:11 -0000 Mailing-List: contact hbase-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hbase-dev@hadoop.apache.org Delivered-To: mailing list hbase-commits@hadoop.apache.org Received: (qmail 46515 invoked by uid 99); 30 Apr 2009 20:08:11 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Apr 2009 20:08:11 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Apr 2009 20:08:09 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id C4CC42388CE0; Thu, 30 Apr 2009 20:07:48 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r770429 - /hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/KeyValue.java Date: Thu, 30 Apr 2009 20:07:48 -0000 To: hbase-commits@hadoop.apache.org From: stack@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090430200748.C4CC42388CE0@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: stack Date: Thu Apr 30 20:07:48 2009 New Revision: 770429 URL: http://svn.apache.org/viewvc?rev=770429&view=rev Log: HBASE-1322 hbase-1234 broke TestAtomicIncrement; fix and reenable Modified: hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/KeyValue.java Modified: hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/KeyValue.java URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/KeyValue.java?rev=770429&r1=770428&r2=770429&view=diff ============================================================================== --- hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/KeyValue.java (original) +++ hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/KeyValue.java Thu Apr 30 20:07:48 2009 @@ -466,7 +466,8 @@ return bytes; } - // Needed doing 'contains' on List. + // Needed doing 'contains' on List. Only compares the key portion, not the + // value. public boolean equals(Object other) { KeyValue kv = (KeyValue)other; // Comparing bytes should be fine doing equals test. Shouldn't have to @@ -960,7 +961,9 @@ } /** - * Compare KeyValues. + * Compare KeyValues. When we compare KeyValues, we only compare the Key + * portion. This means two KeyValues with same Key but different Values are + * considered the same as far as this Comparator is concerned. * Hosts a {@link KeyComparator}. */ public static class KVComparator implements java.util.Comparator { @@ -1316,7 +1319,7 @@ } /** - * Compare key portion of a {@link KeyValue} + * Compare key portion of a {@link KeyValue}. */ public static class KeyComparator implements RawComparator { volatile boolean ignoreTimestamp = false;