hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@apache.org
Subject svn commit: r755712 - in /hadoop/hbase/trunk: CHANGES.txt src/java/org/apache/hadoop/hbase/regionserver/HLogEdit.java
Date Wed, 18 Mar 2009 19:42:35 GMT
Author: stack
Date: Wed Mar 18 19:42:35 2009
New Revision: 755712

URL: http://svn.apache.org/viewvc?rev=755712&view=rev
Log:
HBASE-1265 HLogEdit static constants should be final.

Modified:
    hadoop/hbase/trunk/CHANGES.txt
    hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/HLogEdit.java

Modified: hadoop/hbase/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/CHANGES.txt?rev=755712&r1=755711&r2=755712&view=diff
==============================================================================
--- hadoop/hbase/trunk/CHANGES.txt (original)
+++ hadoop/hbase/trunk/CHANGES.txt Wed Mar 18 19:42:35 2009
@@ -97,6 +97,7 @@
                (Jonathan Gray via Stack)
    HBASE-1258,1259 ganglia metrics for 'requests' is confusing
                (Ryan Rawson via Stack)
+   HBASE-1265  HLogEdit static constants should be final (Nitay Joffe via Stack)
 
 Release 0.19.0 - 01/21/2009
   INCOMPATIBLE CHANGES

Modified: hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/HLogEdit.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/HLogEdit.java?rev=755712&r1=755711&r2=755712&view=diff
==============================================================================
--- hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/HLogEdit.java (original)
+++ hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/HLogEdit.java Wed Mar
18 19:42:35 2009
@@ -38,20 +38,11 @@
 public class HLogEdit implements Writable, HConstants {
 
   /** Value stored for a deleted item */
-  public static byte [] DELETED_BYTES = null;
+  public static final byte [] DELETED_BYTES = Bytes.toBytes("HBASE::DELETEVAL");
 
   /** Value written to HLog on a complete cache flush */
-  public static byte [] COMPLETE_CACHE_FLUSH = null;
+  public static final byte [] COMPLETE_CACHE_FLUSH = Bytes.toBytes("HBASE::CACHEFLUSH");
 
-  static {
-    try {
-      DELETED_BYTES = "HBASE::DELETEVAL".getBytes(UTF8_ENCODING);
-      COMPLETE_CACHE_FLUSH = "HBASE::CACHEFLUSH".getBytes(UTF8_ENCODING);
-    } catch (UnsupportedEncodingException e) {
-      assert(false);
-    }
-  }
-  
   /**
    * @param value
    * @return True if an entry and its content is {@link #DELETED_BYTES}.



Mime
View raw message