Return-Path: Delivered-To: apmail-hadoop-hbase-commits-archive@locus.apache.org Received: (qmail 66479 invoked from network); 14 Mar 2008 02:58:53 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 14 Mar 2008 02:58:53 -0000 Received: (qmail 17092 invoked by uid 500); 14 Mar 2008 02:58:50 -0000 Delivered-To: apmail-hadoop-hbase-commits-archive@hadoop.apache.org Received: (qmail 17070 invoked by uid 500); 14 Mar 2008 02:58:50 -0000 Mailing-List: contact hbase-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hbase-dev@hadoop.apache.org Delivered-To: mailing list hbase-commits@hadoop.apache.org Received: (qmail 17061 invoked by uid 99); 14 Mar 2008 02:58:50 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Mar 2008 19:58:50 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Mar 2008 02:58:10 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 569C81A983E; Thu, 13 Mar 2008 19:58:30 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r636972 - in /hadoop/hbase: branches/0.1/src/java/org/apache/hadoop/hbase/util/Sleeper.java trunk/src/java/org/apache/hadoop/hbase/util/Sleeper.java Date: Fri, 14 Mar 2008 02:58:30 -0000 To: hbase-commits@hadoop.apache.org From: stack@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20080314025830.569C81A983E@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: stack Date: Thu Mar 13 19:58:29 2008 New Revision: 636972 URL: http://svn.apache.org/viewvc?rev=636972&view=rev Log: HBASE-501 Empty region server address in info:server entry and a startcode of -1 in .META. M trunk/src/java/org/apache/hadoop/hbase/util/Sleeper.java M branches/0.1/src/java/org/apache/hadoop/hbase/util/Sleeper.java Improve the log message; last night I saw an instance of this message: i.e. we asked to sleep 3 seconds but we slept > 30 seconds (Default lease timeout between regionserver and master is 30 seconds). . Modified: hadoop/hbase/branches/0.1/src/java/org/apache/hadoop/hbase/util/Sleeper.java hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/util/Sleeper.java Modified: hadoop/hbase/branches/0.1/src/java/org/apache/hadoop/hbase/util/Sleeper.java URL: http://svn.apache.org/viewvc/hadoop/hbase/branches/0.1/src/java/org/apache/hadoop/hbase/util/Sleeper.java?rev=636972&r1=636971&r2=636972&view=diff ============================================================================== --- hadoop/hbase/branches/0.1/src/java/org/apache/hadoop/hbase/util/Sleeper.java (original) +++ hadoop/hbase/branches/0.1/src/java/org/apache/hadoop/hbase/util/Sleeper.java Thu Mar 13 19:58:29 2008 @@ -70,8 +70,10 @@ if (waitTime > 0) { try { Thread.sleep(waitTime); - if ((System.currentTimeMillis() - now) > (10 * this.period)) { - LOG.warn("We slept ten times longer than scheduled: " + this.period); + long slept = System.currentTimeMillis() - now; + if (slept > (10 * this.period)) { + LOG.warn("We slept " + slept + "ms, ten times longer than scheduled: " + + this.period); } } catch(InterruptedException iex) { // We we interrupted because we're meant to stop? If not, just @@ -82,4 +84,4 @@ } } } -} \ No newline at end of file +} Modified: hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/util/Sleeper.java URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/util/Sleeper.java?rev=636972&r1=636971&r2=636972&view=diff ============================================================================== --- hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/util/Sleeper.java (original) +++ hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/util/Sleeper.java Thu Mar 13 19:58:29 2008 @@ -70,8 +70,10 @@ if (waitTime > 0) { try { Thread.sleep(waitTime); - if ((System.currentTimeMillis() - now) > (10 * this.period)) { - LOG.warn("We slept ten times longer than scheduled: " + this.period); + long slept = System.currentTimeMillis() - now; + if (slept > (10 * this.period)) { + LOG.warn("We slept " + slept + "ms, ten times longer than scheduled: " + + this.period); } } catch(InterruptedException iex) { // We we interrupted because we're meant to stop? If not, just