hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@apache.org
Subject svn commit: r636972 - in /hadoop/hbase: branches/0.1/src/java/org/apache/hadoop/hbase/util/Sleeper.java trunk/src/java/org/apache/hadoop/hbase/util/Sleeper.java
Date Fri, 14 Mar 2008 02:58:30 GMT
Author: stack
Date: Thu Mar 13 19:58:29 2008
New Revision: 636972

URL: http://svn.apache.org/viewvc?rev=636972&view=rev
Log:
HBASE-501 Empty region server address in info:server entry and a startcode of -1 in .META.
M    trunk/src/java/org/apache/hadoop/hbase/util/Sleeper.java
M    branches/0.1/src/java/org/apache/hadoop/hbase/util/Sleeper.java
    Improve the log message; last night I saw an instance of this message: i.e.
    we asked to sleep 3 seconds but we slept > 30 seconds (Default
    lease timeout between regionserver and master is 30 seconds).
    .


Modified:
    hadoop/hbase/branches/0.1/src/java/org/apache/hadoop/hbase/util/Sleeper.java
    hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/util/Sleeper.java

Modified: hadoop/hbase/branches/0.1/src/java/org/apache/hadoop/hbase/util/Sleeper.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/branches/0.1/src/java/org/apache/hadoop/hbase/util/Sleeper.java?rev=636972&r1=636971&r2=636972&view=diff
==============================================================================
--- hadoop/hbase/branches/0.1/src/java/org/apache/hadoop/hbase/util/Sleeper.java (original)
+++ hadoop/hbase/branches/0.1/src/java/org/apache/hadoop/hbase/util/Sleeper.java Thu Mar 13
19:58:29 2008
@@ -70,8 +70,10 @@
     if (waitTime > 0) {
       try {
         Thread.sleep(waitTime);
-        if ((System.currentTimeMillis() - now) > (10 * this.period)) {
-          LOG.warn("We slept ten times longer than scheduled: " + this.period);
+        long slept = System.currentTimeMillis() - now;
+        if (slept > (10 * this.period)) {
+          LOG.warn("We slept " + slept + "ms, ten times longer than scheduled: " +
+            this.period);
         }
       } catch(InterruptedException iex) {
         // We we interrupted because we're meant to stop?  If not, just
@@ -82,4 +84,4 @@
       }
     }
   }
-}
\ No newline at end of file
+}

Modified: hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/util/Sleeper.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/util/Sleeper.java?rev=636972&r1=636971&r2=636972&view=diff
==============================================================================
--- hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/util/Sleeper.java (original)
+++ hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/util/Sleeper.java Thu Mar 13 19:58:29
2008
@@ -70,8 +70,10 @@
     if (waitTime > 0) {
       try {
         Thread.sleep(waitTime);
-        if ((System.currentTimeMillis() - now) > (10 * this.period)) {
-          LOG.warn("We slept ten times longer than scheduled: " + this.period);
+        long slept = System.currentTimeMillis() - now;
+        if (slept > (10 * this.period)) {
+          LOG.warn("We slept " + slept + "ms, ten times longer than scheduled: " +
+            this.period);
         }
       } catch(InterruptedException iex) {
         // We we interrupted because we're meant to stop?  If not, just



Mime
View raw message