From issues-return-18821-archive-asf-public=cust-asf.ponee.io@hawq.incubator.apache.org Wed Aug 8 04:01:56 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7E867180657 for ; Wed, 8 Aug 2018 04:01:55 +0200 (CEST) Received: (qmail 52438 invoked by uid 500); 8 Aug 2018 02:01:54 -0000 Mailing-List: contact issues-help@hawq.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hawq.incubator.apache.org Delivered-To: mailing list issues@hawq.incubator.apache.org Received: (qmail 52429 invoked by uid 99); 8 Aug 2018 02:01:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Aug 2018 02:01:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 3EF87181238 for ; Wed, 8 Aug 2018 02:01:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4 X-Spam-Level: X-Spam-Status: No, score=-4 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id wOh8VeZm_qE3 for ; Wed, 8 Aug 2018 02:01:53 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 27A7F5F41B for ; Wed, 8 Aug 2018 02:01:51 +0000 (UTC) Received: (qmail 52393 invoked by uid 99); 8 Aug 2018 02:01:51 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Aug 2018 02:01:51 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 4F192DFC7C; Wed, 8 Aug 2018 02:01:51 +0000 (UTC) From: huor To: issues@hawq.incubator.apache.org Reply-To: issues@hawq.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external... Content-Type: text/plain Message-Id: <20180808020151.4F192DFC7C@git1-us-west.apache.org> Date: Wed, 8 Aug 2018 02:01:51 +0000 (UTC) Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208436378 --- Diff: src/backend/commands/tablecmds.c --- @@ -17615,14 +17979,16 @@ static Datum transformLocationUris(List *locs, List* fmtopts, bool isweb, bool i errhint("Writable external tables may use \'gpfdist(s)\' URIs only."), errOmitLocation(true))); - if(uri->protocol != URI_CUSTOM && iswritable && strchr(uri->path, '*')) + if(uri->protocol != URI_CUSTOM && uri->protocol != URI_MAGMA && iswritable && strchr(uri->path, '*')) --- End diff -- No magma ---