hawq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From divyabhargov <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request #1383: HAWQ-1644. Make delegation token optional...
Date Thu, 09 Aug 2018 12:05:10 GMT
Github user divyabhargov commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1383#discussion_r208903549
  
    --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/utilities/SecuredHDFS.java
---
    @@ -45,28 +45,33 @@
          *
          * All token properties will be deserialized from string to a Token object
          *
    -     * @param protData input parameters
    +     * @param userGroupInformation the UGI for token verification
    +     * @param tokenString (optional) the delegation token
          * @param context servlet context which contains the NN address
          *
          * @throws SecurityException Thrown when authentication fails
          */
    -    public static void verifyToken(ProtocolData protData, ServletContext context) {
    +    public static void verifyToken(UserGroupInformation userGroupInformation,
    +                                   String tokenString,
    +                                   ServletContext context) {
             try {
                 if (UserGroupInformation.isSecurityEnabled()) {
                     /*
    -                 * HAWQ-1215: The verify token method validates that the token sent from
    +                 * The verify token method validates that the token sent from
    --- End diff --
    
    Was removing the HAWQ reference story from the comment accidental?


---

Mime
View raw message