hawq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Librago <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...
Date Thu, 09 Aug 2018 08:04:47 GMT
Github user Librago commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1384#discussion_r208435844
  
    --- Diff: src/backend/access/external/fileam.c ---
    @@ -1290,6 +1397,97 @@ externalgettup_custom(FileScanDesc scan, ExternalSelectDesc desc,
ScanState *ss)
     		return NULL;
     }
     
    +static HeapTuple
    +externalgettup_custom_noextprot(FileScanDesc scan,
    +								ExternalSelectDesc desc,
    +								ScanState *ss)
    +{
    +	HeapTuple   	tuple;
    +	CopyState		pstate = scan->fs_pstate;
    +	FormatterData*	formatter = scan->fs_formatter;
    +	bool			no_more_data = false;
    +	MemoryContext 	oldctxt = CurrentMemoryContext;
    +
    +	Assert(formatter);
    +
    +	/* while didn't finish processing the entire file */
    +	while (!no_more_data)
    +	{
    +		bool error_caught = false;
    +
    +		/*
    +		 * Invoke the custom formatter function.
    +		 */
    +		PG_TRY();
    +		{
    +			Datum					d;
    +			FunctionCallInfoData	fcinfo;
    --- End diff --
    
    incorrect indent


---

Mime
View raw message