hawq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From benchristel <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request #1381: Remove autogeneration of version number f...
Date Thu, 12 Jul 2018 21:06:20 GMT
GitHub user benchristel opened a pull request:

    https://github.com/apache/incubator-hawq/pull/1381

    Remove autogeneration of version number from pxf/build.gradle

    **NOT READY TO MERGE**. The purpose of this PR is to solicit feedback on our approach.
We'll need to do more work to get the hardcoded version number out of this code.
    
    This enables us to use IntelliJ's code navigation and refactoring
    features. Previously, IntelliJ would navigate to / refactor the
    generated files rather than the source files since the generated files
    were the ones that actually got compiled.
    
    We also upgraded Gradle to 3.0 because we suspected IntelliJ might not have good support
for older Gradle versions. We may want to revert the change to the Gradle version if it wasn't
the culprit.
    
    Co-authored-by: Lav Jain <ljain@pivotal.io>
    Co-authored-by: Ben Christel <bchristel@pivotal.io>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lavjain/incubator-hawq support-intellij-refactoring

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hawq/pull/1381.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1381
    
----
commit c3ba4a5312283cca3bf820a312da5428458be704
Author: Francisco Guerrero <aguerrero@...>
Date:   2018-07-12T20:59:55Z

    Remove autogeneration of version number from pxf/build.gradle
    
    This enables us to use IntelliJ's code navigation and refactoring
    features. Previously, IntelliJ would navigate to / refactor the
    generated files rather than the source files since the generated files
    were the ones that actually got compiled.
    
    Co-authored-by: Francisco Guerrero <aguerrero@pivotal.io>
    Co-authored-by: Ben Christel <bchristel@pivotal.io>

----


---

Mime
View raw message