hawq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From denalex <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request #1379: HAWQ-1622. Cache PXF proxy UGI so that cl...
Date Tue, 10 Jul 2018 23:23:57 GMT
Github user denalex commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1379#discussion_r201513391
  
    --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/SessionId.java ---
    @@ -0,0 +1,60 @@
    +package org.apache.hawq.pxf.service;
    +
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +public class SessionId {
    +
    +    private final String user;
    +    private Integer segmentId;
    +    private String sessionId;
    +
    +    public SessionId(Integer segmentId, String transactionId, String gpdbUser) {
    +        this.segmentId = segmentId;
    +        this.user = gpdbUser;
    +        this.sessionId = segmentId + ":" + transactionId + ":" + gpdbUser;
    +    }
    +
    +    public Integer getSegmentId() {
    +        return segmentId;
    +    }
    +
    +    @Override
    +    public int hashCode() {
    +        return sessionId.hashCode();
    +    }
    +
    +    @Override
    +    public boolean equals(Object other) {
    +        if (!(other instanceof SessionId)) {
    +            return false;
    +        }
    +        SessionId that = (SessionId) other;
    +        return this.sessionId.equals(that.sessionId);
    --- End diff --
    
    I usually follow the pattern and utility methods from: https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/builder/EqualsBuilder.html


---

Mime
View raw message