From issues-return-18350-archive-asf-public=cust-asf.ponee.io@hawq.incubator.apache.org Thu May 10 05:31:16 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 89294180649 for ; Thu, 10 May 2018 05:31:15 +0200 (CEST) Received: (qmail 38065 invoked by uid 500); 10 May 2018 03:31:14 -0000 Mailing-List: contact issues-help@hawq.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hawq.incubator.apache.org Delivered-To: mailing list issues@hawq.incubator.apache.org Received: (qmail 38048 invoked by uid 99); 10 May 2018 03:31:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 May 2018 03:31:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 34F7FC0333 for ; Thu, 10 May 2018 03:31:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.01 X-Spam-Level: X-Spam-Status: No, score=-4.01 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id NYeJqtY0nDdv for ; Thu, 10 May 2018 03:31:13 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 1913B5F27D for ; Thu, 10 May 2018 03:31:12 +0000 (UTC) Received: (qmail 37718 invoked by uid 99); 10 May 2018 03:31:12 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 May 2018 03:31:12 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id BF0E6DFF06; Thu, 10 May 2018 03:31:11 +0000 (UTC) From: interma To: issues@hawq.incubator.apache.org Reply-To: issues@hawq.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-hawq pull request #1361: HAWQ-1612. Implement vectorized aggregate... Content-Type: text/plain Message-Id: <20180510033111.BF0E6DFF06@git1-us-west.apache.org> Date: Thu, 10 May 2018 03:31:11 +0000 (UTC) Github user interma commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1361#discussion_r187230968 --- Diff: contrib/vexecutor/vagg.h --- @@ -0,0 +1,94 @@ +#ifndef VAGG_H +#define VAGG_H + +#include "executor/execHHashagg.h" + +/* batch hashagg group linklist header */ +typedef struct GroupData { + HashAggEntry *entry; // pointer to agg_hash_entry + int idx; // pointer to idx_list --- End diff -- Refine my poor comments: 1. use /**/ instead //. 2. unify the ident. ---