From issues-return-18322-archive-asf-public=cust-asf.ponee.io@hawq.incubator.apache.org Tue May 1 18:59:54 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3DC28180645 for ; Tue, 1 May 2018 18:59:54 +0200 (CEST) Received: (qmail 15894 invoked by uid 500); 1 May 2018 16:59:53 -0000 Mailing-List: contact issues-help@hawq.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hawq.incubator.apache.org Delivered-To: mailing list issues@hawq.incubator.apache.org Received: (qmail 15885 invoked by uid 99); 1 May 2018 16:59:53 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 May 2018 16:59:53 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D23DE1A1FC1 for ; Tue, 1 May 2018 16:59:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.01 X-Spam-Level: X-Spam-Status: No, score=-4.01 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id UHuib0URqqO3 for ; Tue, 1 May 2018 16:59:52 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 9CDDF5F23C for ; Tue, 1 May 2018 16:59:51 +0000 (UTC) Received: (qmail 15869 invoked by uid 99); 1 May 2018 16:59:51 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 May 2018 16:59:51 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id BD706E17C3; Tue, 1 May 2018 16:59:50 +0000 (UTC) From: mgoddard-pivotal To: issues@hawq.incubator.apache.org Reply-To: issues@hawq.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-hawq pull request #1357: Changes to enable reuse of PXF Parquet cl... Content-Type: text/plain Message-Id: <20180501165950.BD706E17C3@git1-us-west.apache.org> Date: Tue, 1 May 2018 16:59:50 +0000 (UTC) Github user mgoddard-pivotal commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1357#discussion_r185272600 --- Diff: pxf/pxf-hdfs/src/main/java/org/apache/hawq/pxf/plugins/hdfs/ParquetResolver.java --- @@ -55,6 +56,16 @@ public ParquetResolver(InputData metaData) { super(metaData); } + // This method facilitates passing in the MessageType instance, which is --- End diff -- @shivzone, I've switched to a Javadoc style comment. Does this work? ---