hawq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mgoddard-pivotal <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request #1365: Adding equals() to Fragment, to facilitat...
Date Tue, 15 May 2018 15:37:20 GMT
GitHub user mgoddard-pivotal opened a pull request:

    https://github.com/apache/incubator-hawq/pull/1365

    Adding equals() to Fragment, to facilitate comparisons in tests

    Writing some unit tests for the PXF + S3 + Parquet code, and the equals() was necessary.
 Also, added hashCode() to this class.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mgoddard-pivotal/incubator-hawq add-fragment-equals

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hawq/pull/1365.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1365
    
----
commit 5a431fa477e9633a706b700369e771058b3c59bd
Author: Michael Goddard <mgoddard@...>
Date:   2018-05-14T21:24:55Z

    Adding an equals() method to Fragment to facilitate tests involving methods returning
Fragment

commit 12682835dbc8eb779812cbb8b1cf36f15ed974da
Author: Michael Goddard <mgoddard@...>
Date:   2018-05-15T00:03:08Z

    Revert "Adding an equals() method to Fragment to facilitate tests involving methods returning
Fragment"
    
    This reverts commit 5a431fa477e9633a706b700369e771058b3c59bd.

commit 00ae9ba688708cb8cbb0b2e9f43ddcf8f88182e7
Author: Michael Goddard <mgoddard@...>
Date:   2018-05-15T15:34:27Z

    Adding equals() and hashCode() to Fragment, to facilitate comparisons in tests

----


---

Mime
View raw message