hawq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From interma <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request #1361: HAWQ-1612. Implement vectorized aggregate...
Date Thu, 10 May 2018 03:31:11 GMT
Github user interma commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1361#discussion_r187230968
  
    --- Diff: contrib/vexecutor/vagg.h ---
    @@ -0,0 +1,94 @@
    +#ifndef VAGG_H
    +#define VAGG_H
    +
    +#include "executor/execHHashagg.h"
    +
    +/* batch hashagg group linklist header */
    +typedef struct GroupData {
    +	HashAggEntry *entry;	// pointer to agg_hash_entry
    +	int idx; 				// pointer to idx_list
    --- End diff --
    
    Refine my poor comments:
    1. use /**/ instead //.
    2. unify the ident.



---

Mime
View raw message