hawq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wengyanqing <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request #1358: HAWQ-1609. Implement Vectorized Motion No...
Date Sat, 28 Apr 2018 06:54:00 GMT
Github user wengyanqing commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1358#discussion_r184842905
  
    --- Diff: contrib/vexecutor/tuplebatch.c ---
    @@ -150,19 +150,26 @@ tbSerialization(TupleBatch tb )
         return ret;
     }
     
    -TupleBatch tbDeserialization(unsigned char *buffer)
    +void tbDeserialization(unsigned char *buffer,TupleBatch* pTB )
    --- End diff --
    
    Is tuple batch deserialization always successful ? If not, please use bool for return
value type.


---

Mime
View raw message