hawq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sansanichfb <...@git.apache.org>
Subject [GitHub] incubator-hawq issue #1353: HAWQ-1605. Support INSERT in PXF JDBC plugin
Date Thu, 19 Apr 2018 02:17:07 GMT
Github user sansanichfb commented on the issue:

    https://github.com/apache/incubator-hawq/pull/1353
  
    Good job leskin-in! I left some comments. Also, I am wondering, which target database
patch was tested against? The transactional approach doesn't seem clear to me - if DB doesn't
support transactions - you are still sending data in batches, which might leave target db
in the non-consistent state since you can't rollback the last transaction. Should we reconsider
this approach and send only one batch(not ideal though, maybe ask users to tweak partitioning)
in that case?


---

Mime
View raw message