hawq-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From leskin-in <...@git.apache.org>
Subject [GitHub] incubator-hawq pull request #1344: PXF Ignite plugin
Date Thu, 01 Mar 2018 10:49:48 GMT
Github user leskin-in commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1344#discussion_r171521898
  
    --- Diff: pxf/pxf-ignite/src/main/java/org/apache/hawq/pxf/plugins/ignite/ByteUtil.java
---
    @@ -0,0 +1,77 @@
    +package org.apache.hawq.pxf.plugins.ignite;
    +
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +/**
    + * A tool class, used to deal with byte array split and conversions.
    + * IgnitePartitionFragmenter requires this class in order to work with 'fragmentMetadata'
field
    + */
    +public class ByteUtil {
    +    public static byte[][] splitBytes(byte[] bytes, int n) {
    +        int len = bytes.length / n;
    +        byte[][] newBytes = new byte[len][];
    +        int j = 0;
    +        for (int i = 0; i < len; i++) {
    +            newBytes[i] = new byte[n];
    +            for (int k = 0; k < n; k++) newBytes[i][k] = bytes[j++];
    +        }
    +        return newBytes;
    +    }
    +
    +    public static byte[] getBytes(long value) {
    --- End diff --
    
    Done. Thank you for the comment.
    
    This also eliminates the dependency on Apache Commons ArrayUtils.


---

Mime
View raw message