Mailing-List: contact dev-help@hawq.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hawq.incubator.apache.org
From: jiny2 <git@git.apache.org>
To: dev@hawq.incubator.apache.org
Reply-To: dev@hawq.incubator.apache.org
References: <git-pr-129-incubator-hawq-docs@git.apache.org>
In-Reply-To: <git-pr-129-incubator-hawq-docs@git.apache.org>
Subject: [GitHub] incubator-hawq-docs pull request #129: Update for current implementation of ...
Content-Type: text/plain
Message-Id: <20170830081434.4013EE0395@git1-us-west.apache.org>
Date: Wed, 30 Aug 2017 08:14:33 +0000 (UTC)
archived-at: Wed, 30 Aug 2017 08:14:42 -0000

Github user jiny2 commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq-docs/pull/129#discussion_r135999105
  
    --- Diff: markdown/clientaccess/client_auth.html.md.erb ---
    @@ -99,27 +99,25 @@ This example shows how to edit the `pg_hba.conf` file of the master to allow rem
     
     HAWQ allocates some resources on a per-connection basis, so setting the maximum number of connections allowed is recommended.
     
    -To limit the number of active concurrent sessions to your HAWQ system, you can configure the `max_connections` server configuration parameter on master or the `seg_max_connections` server configuration parameter on segments. These parameters are *local* parameters, meaning that you must set them in the `hawq-site.xml` file of all HAWQ instances.
    +To limit the number of active concurrent sessions to your HAWQ system, you can configure the `max_connections` server configuration parameter. This parameter is a *local* parameter, meaning that you must set them in the `hawq-site.xml` file of all HAWQ instances.
     
    -When you set `max_connections`, you must also set the dependent parameter `max_prepared_transactions`. This value must be at least as large as the value of `max_connections`, and all HAWQ instances should be set to the same value.
    +When you set `max_connections`, you can also set the value for the maximum concurrent connections for the segments by using `seg_max_connections`. Setting this parameter overrides the value of `max_connections` on the segment instances.
     
     Example `$GPHOME/etc/hawq-site.xml` configuration:
     
     ``` xml
       <property>
           <name>max_connections</name>
    -      <value>500</value>
    +      <value>200</value>
    --- End diff --
    
    I am ok with default value changes, as Radar said, if we mentioned the best practice value as 1280 for this guc, maybe it is better to directly change to 1280 to reflect what we recommended. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---